commit 372bcceeee8012ef3fb2f3dbc8132c3a33cb84fc
author LemonBoy <thatlemon@gmail.com> Mon Apr 25 12:43:20 2022 +0100
committer Bram Moolenaar <Bram@vim.org> Mon Apr 25 12:43:20 2022 +0100
tree fd5e5a86cf23a018f653097a7c7477c532316a36
parent af59e34f1bf214ec6f2d0304c1c5b11ecda25a83

patch 8.2.4823: concat more than 2 strings in :def function is inefficient

Problem:    Concatenating more than 2 strings in a :def function is
            inefficient.
Solution:   Add a count to the CONCAT instruction. (closes #10276)

src/vim9cmds.c

diff --git a/src/vim9cmds.c b/src/vim9cmds.c
index a853d9b..ad32c32 100644
--- a/src/vim9cmds.c
+++ b/src/vim9cmds.c
@@ -2125,7 +2125,7 @@
 	    generate_instr_type(cctx, ISN_REDIREND, &t_string);
 
 	    if (lhs->lhs_append)
-		generate_instr_drop(cctx, ISN_CONCAT, 1);
+		generate_CONCAT(cctx, 2);
 
 	    if (lhs->lhs_has_index)
 	    {