patch 8.0.0184: when an error is caught Vim still exits with non-zero result
Problem: When in Ex mode and an error is caught by try-catch, Vim still
exits with a non-zero exit code.
Solution: Don't set ex_exitval when inside a try-catch. (partly by Christian
Brabandt)
diff --git a/src/testdir/test_system.vim b/src/testdir/test_system.vim
index 0446bd9..f82f751 100644
--- a/src/testdir/test_system.vim
+++ b/src/testdir/test_system.vim
@@ -46,3 +46,40 @@
call assert_fails('call system("wc -l", 99999)', 'E86:')
endfunction
+
+function! Test_system_exmode()
+ let cmd=" -es -u NONE -c 'source Xscript' +q; echo $?"
+ " Need to put this in a script, "catch" isn't found after an unknown
+ " function.
+ call writefile(['try', 'call doesnotexist()', 'catch', 'endtry'], 'Xscript')
+ let a = system(v:progpath . cmd)
+ call assert_equal('0', a[0])
+ call assert_equal(0, v:shell_error)
+
+ " Error before try does set error flag.
+ call writefile(['call nosuchfunction()', 'try', 'call doesnotexist()', 'catch', 'endtry'], 'Xscript')
+ let a = system(v:progpath . cmd)
+ call assert_notequal('0', a[0])
+
+ let cmd=" -es -u NONE -c 'source Xscript' +q"
+ let a = system(v:progpath . cmd)
+ call assert_notequal(0, v:shell_error)
+
+ let cmd=" -es -u NONE -c 'call doesnotexist()' +q; echo $?"
+ let a = system(v:progpath. cmd)
+ call assert_notequal(0, a[0])
+
+ let cmd=" -es -u NONE -c 'call doesnotexist()' +q"
+ let a = system(v:progpath. cmd)
+ call assert_notequal(0, v:shell_error)
+
+ let cmd=" -es -u NONE -c 'call doesnotexist()|let a=1' +q; echo $?"
+ let a = system(v:progpath. cmd)
+ call assert_notequal(0, a[0])
+
+ let cmd=" -es -u NONE -c 'call doesnotexist()|let a=1' +q"
+ let a = system(v:progpath. cmd)
+ call assert_notequal(0, v:shell_error)
+
+ call delete('Xscript')
+endfunc