commit 2b6ef856fb89f703714f3f1f567d9bd7c81079f3
author Bram Moolenaar <Bram@vim.org> Sat Jul 11 22:25:57 2020 +0200
committer Bram Moolenaar <Bram@vim.org> Sat Jul 11 22:25:57 2020 +0200
tree 56ff0fbf54221a5518d0a31c6a05ac811b52e3ca
parent 9b7bf9e98f06ece595fed7a3ff53ecce89797a53

patch 8.2.1184: some tests fail

Problem:    Some tests fail.
Solution:   Adjust tests for different assert_fails() behavior.  Remove unused
            variable.

src/evalvars.c

diff --git a/src/evalvars.c b/src/evalvars.c
index 7066039..6e67206 100644
--- a/src/evalvars.c
+++ b/src/evalvars.c
@@ -3389,7 +3389,6 @@
 var_redir_start(char_u *name, int append)
 {
     int		called_emsg_before;
-    int		err;
     typval_T	tv;
 
     // Catch a bad name early.

src/testdir/test_assert.vim

diff --git a/src/testdir/test_assert.vim b/src/testdir/test_assert.vim
index c2d055c..0ec710a 100644
--- a/src/testdir/test_assert.vim
+++ b/src/testdir/test_assert.vim
@@ -208,12 +208,12 @@
 endfunc
 
 func Test_assert_fail_fails()
-  call assert_equal(1, assert_fails('xxx', {}))
-  call assert_match("Expected {} but got 'E731:", v:errors[0])
+  call assert_equal(1, assert_fails('xxx', 'E12345'))
+  call assert_match("Expected 'E12345' but got 'E492:", v:errors[0])
   call remove(v:errors, 0)
 
-  call assert_equal(1, assert_fails('xxx', {}, 'stupid'))
-  call assert_match("stupid: Expected {} but got 'E731:", v:errors[0])
+  call assert_equal(1, assert_fails('xxx', 'E9876', 'stupid'))
+  call assert_match("stupid: Expected 'E9876' but got 'E492:", v:errors[0])
   call remove(v:errors, 0)
 
   call assert_equal(1, assert_fails('echo', '', 'echo command'))

src/testdir/test_eval_stuff.vim

diff --git a/src/testdir/test_eval_stuff.vim b/src/testdir/test_eval_stuff.vim
index 3a229b5..6d95cc0 100644
--- a/src/testdir/test_eval_stuff.vim
+++ b/src/testdir/test_eval_stuff.vim
@@ -1,5 +1,7 @@
 " Tests for various eval things.
 
+source view_util.vim
+
 function s:foo() abort
   try
     return [] == 0
@@ -17,13 +19,8 @@
     throw 1
   catch
   endtry
-  echoerr 'wrong'
-  let c1 = nr2char(screenchar(&lines, 1))
-  let c2 = nr2char(screenchar(&lines, 2))
-  let c3 = nr2char(screenchar(&lines, 3))
-  let c4 = nr2char(screenchar(&lines, 4))
-  let c5 = nr2char(screenchar(&lines, 5))
-  call assert_equal('wrong', c1 . c2 . c3 . c4 . c5)
+  echoerr 'wrong again'
+  call assert_equal('wrong again', ScreenLine(&lines))
 endfunc
 
 func Test_mkdir_p()

src/version.c

diff --git a/src/version.c b/src/version.c
index ece1006..7c3ee48 100644
--- a/src/version.c
+++ b/src/version.c
@@ -755,6 +755,8 @@
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    1184,
+/**/
     1183,
 /**/
     1182,