commit 21578271bb717f7ab7b8728e9efa54c3b60ee7e4
author Bram Moolenaar <Bram@vim.org> Sun Feb 21 19:12:47 2021 +0100
committer Bram Moolenaar <Bram@vim.org> Sun Feb 21 19:12:47 2021 +0100
tree bc84fb32dacad216019810d5702e13aca8d83133
parent 027c4ab4d2e3ff031b98e0fb648f5acbea180293

patch 8.2.2538: crash when using Python list iterator

Problem:    Crash when using Python list iterator.
Solution:   Increment the list reference count. (closes #7886)

src/if_py_both.h

diff --git a/src/if_py_both.h b/src/if_py_both.h
index 2903b0b..9dbff1c 100644
--- a/src/if_py_both.h
+++ b/src/if_py_both.h
@@ -2815,6 +2815,7 @@
 ListIterDestruct(listiterinfo_T *lii)
 {
     list_rem_watch(lii->list, &lii->lw);
+    list_unref(lii->list);
     PyMem_Free(lii);
 }
 
@@ -2850,6 +2851,7 @@
     list_add_watch(l, &lii->lw);
     lii->lw.lw_item = l->lv_first;
     lii->list = l;
+    ++l->lv_refcount;
 
     return IterNew(lii,
 	    (destructorfun) ListIterDestruct, (nextfun) ListIterNext,

src/testdir/test_python3.vim

diff --git a/src/testdir/test_python3.vim b/src/testdir/test_python3.vim
index 6afb76d..58b6427 100644
--- a/src/testdir/test_python3.vim
+++ b/src/testdir/test_python3.vim
@@ -574,6 +574,9 @@
   py3 ll[2] = 8
   call assert_equal([1, 2, 8], l)
 
+  " iterating over list from Python
+  py3 print([x for x in vim.Function("getline")(1, 2)])
+
   " Using dict as an index
   call AssertException(['py3 ll[{}] = 10'],
         \ 'Vim(py3):TypeError: index must be int or slice, not dict')

src/version.c

diff --git a/src/version.c b/src/version.c
index 8d29d52..a64037d 100644
--- a/src/version.c
+++ b/src/version.c
@@ -751,6 +751,8 @@
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    2538,
+/**/
     2537,
 /**/
     2536,