patch 8.1.1518: crash when setting 'columns' while a popup is visible
Problem: Crash when setting 'columns' while a popup is visible.
Solution: Recompute all positions when clearing the screen. (closes #4467)
diff --git a/src/testdir/dumps/Test_popupwin_04a.dump b/src/testdir/dumps/Test_popupwin_04a.dump
new file mode 100644
index 0000000..2e6b6ac
--- /dev/null
+++ b/src/testdir/dumps/Test_popupwin_04a.dump
@@ -0,0 +1,10 @@
+> +0&#ffffff0@11
+|~+0#4040ff13&| @10
+|~| @10
+|~| @6|o+0#0000001#ffd7ff255|t|h|e
+|~+0#4040ff13#ffffff0| @6|r+0#0000001#ffd7ff255| |t|a
+|~+0#4040ff13#ffffff0| @6|b+0#0000001#ffd7ff255| @2
+|~+0#4040ff13#ffffff0| @6|a+0#0000001#ffd7ff255| |c+0#ff404010&|o
+|~+0#4040ff13#ffffff0| @6|m+0#ff404010#ffd7ff255@1|e|n
+|~+0#4040ff13#ffffff0| @6|t+0#ff404010#ffd7ff255| +0#0000001&|l|i
+| +0#0000000#ffffff0@5|0|,|n+0#0000001#ffd7ff255|e| @1
diff --git a/src/testdir/test_popupwin.vim b/src/testdir/test_popupwin.vim
index 51eed30..06a33d4 100644
--- a/src/testdir/test_popupwin.vim
+++ b/src/testdir/test_popupwin.vim
@@ -41,6 +41,12 @@
call term_sendkeys(buf, ":quit!\<CR>")
call VerifyScreenDump(buf, 'Test_popupwin_04', {})
+ " set 'columns' to a small value, size must be recomputed
+ call term_sendkeys(buf, ":let cols = &columns\<CR>")
+ call term_sendkeys(buf, ":set columns=12\<CR>")
+ call VerifyScreenDump(buf, 'Test_popupwin_04a', {})
+ call term_sendkeys(buf, ":let &columns = cols\<CR>")
+
" resize popup, show empty line at bottom
call term_sendkeys(buf, ":call popup_move(popupwin, {'minwidth': 15, 'maxwidth': 25, 'minheight': 3, 'maxheight': 5})\<CR>")
call term_sendkeys(buf, ":redraw\<CR>")