commit 1cfb14aa972ccf3235ac67f07b7db1175b7c5384
author Yegappan Lakshmanan <yegappan@yahoo.com> Mon Jan 09 19:04:23 2023 +0000
committer Bram Moolenaar <Bram@vim.org> Mon Jan 09 19:04:23 2023 +0000
tree b746eda548993b9e0987d7c9c0c543ddddc5758f
parent 765d82a657c5e42d5d7c88ae410e53f398c34c43

patch 9.0.1166: code is indented more than necessary

Problem:    Code is indented more than necessary.
Solution:   Use an early return where it makes sense. (Yegappan Lakshmanan,
            closes #11792)

src/filepath.c

diff --git a/src/filepath.c b/src/filepath.c
index 023c732..be1a581 100644
--- a/src/filepath.c
+++ b/src/filepath.c
@@ -3084,13 +3084,13 @@
     char_u  *dest;
 
     dest = alloc(STRLEN(fname1) + STRLEN(fname2) + 3);
-    if (dest != NULL)
-    {
-	STRCPY(dest, fname1);
-	if (sep)
-	    add_pathsep(dest);
-	STRCAT(dest, fname2);
-    }
+    if (dest == NULL)
+	return NULL;
+
+    STRCPY(dest, fname1);
+    if (sep)
+	add_pathsep(dest);
+    STRCAT(dest, fname2);
     return dest;
 }
 
@@ -3122,14 +3122,14 @@
 	return NULL;
 
     buf = alloc(MAXPATHL);
-    if (buf != NULL)
-    {
-	if (vim_FullName(fname, buf, MAXPATHL, force) != FAIL)
-	    new_fname = vim_strsave(buf);
-	else
-	    new_fname = vim_strsave(fname);
-	vim_free(buf);
-    }
+    if (buf == NULL)
+	return NULL;
+
+    if (vim_FullName(fname, buf, MAXPATHL, force) != FAIL)
+	new_fname = vim_strsave(buf);
+    else
+	new_fname = vim_strsave(fname);
+    vim_free(buf);
     return new_fname;
 }