patch 9.0.0708: :confirm does not work properly for a terminal buffer
Problem: :confirm does not work properly for a terminal buffer.
Solution: Handle :confirm for a terminal buffer differently. (Yee Cheng
Chin, closes #11312)
diff --git a/src/ex_docmd.c b/src/ex_docmd.c
index 8ca5ede..f5b3980 100644
--- a/src/ex_docmd.c
+++ b/src/ex_docmd.c
@@ -6061,13 +6061,27 @@
#if defined(FEAT_GUI_DIALOG) || defined(FEAT_CON_DIALOG)
if ((p_confirm || (cmdmod.cmod_flags & CMOD_CONFIRM)) && p_write)
{
- bufref_T bufref;
+# ifdef FEAT_TERMINAL
+ if (term_job_running(buf->b_term))
+ {
+ if (term_confirm_stop(buf) == FAIL)
+ return;
+ // Manually kill the terminal here because this command will
+ // hide it otherwise.
+ free_terminal(buf);
+ need_hide = FALSE;
+ }
+ else
+# endif
+ {
+ bufref_T bufref;
- set_bufref(&bufref, buf);
- dialog_changed(buf, FALSE);
- if (bufref_valid(&bufref) && bufIsChanged(buf))
- return;
- need_hide = FALSE;
+ set_bufref(&bufref, buf);
+ dialog_changed(buf, FALSE);
+ if (bufref_valid(&bufref) && bufIsChanged(buf))
+ return;
+ need_hide = FALSE;
+ }
}
else
#endif