commit 11ec807639ae642bf55da883918489e2cd9911ab
author Bram Moolenaar <Bram@vim.org> Thu Feb 20 20:12:29 2020 +0100
committer Bram Moolenaar <Bram@vim.org> Thu Feb 20 20:12:29 2020 +0100
tree 14706a1435fe7a0b74dd1d95f61902df2345c424
parent 0bbf722aaaa75b1bbe87ef6afc44c5fff8e3893b

patch 8.2.0286: cannot use popup_close() for a terminal popup

Problem:    Cannot use popup_close() for a terminal popup.
Solution:   Allow using popup_close(). (closes #5666)

src/popupwin.c

diff --git a/src/popupwin.c b/src/popupwin.c
index 56d04b5..4078378 100644
--- a/src/popupwin.c
+++ b/src/popupwin.c
@@ -2360,7 +2360,12 @@
     int		id = (int)tv_get_number(argvars);
     win_T	*wp;
 
-    if (ERROR_IF_ANY_POPUP_WINDOW)
+    if (
+# ifdef FEAT_TERMINAL
+	// if the popup contains a terminal it will become hidden
+	curbuf->b_term == NULL &&
+# endif
+	    ERROR_IF_ANY_POPUP_WINDOW)
 	return;
 
     wp = find_popup_win(id);