commit 0d8562a9992e94d532485c37268ca33c0c49ecc2
author Bram Moolenaar <Bram@vim.org> Tue Feb 19 21:34:05 2019 +0100
committer Bram Moolenaar <Bram@vim.org> Tue Feb 19 21:34:05 2019 +0100
tree a91ad1f6f9aef842d1a9cfaa2c8e604de9dce3ce
parent c9629251a634d4f5988c8162ba8249026d1af687

patch 8.1.0954: arguments of semsg() and siemsg() are not checked

Problem:    Arguments of semsg() and siemsg() are not checked.
Solution:   Add function prototype with __attribute__.

src/message.c

diff --git a/src/message.c b/src/message.c
index 621edb9..a7aca2b 100644
--- a/src/message.c
+++ b/src/message.c
@@ -730,6 +730,7 @@
     return TRUE;		/* no error messages at the moment */
 }
 
+#ifndef PROTO  // manual proto with __attribute__
 /*
  * Print an error message with format string and variable arguments.
  * Note: caller must not pass 'IObuff' as 1st argument.
@@ -749,6 +750,7 @@
     }
     return TRUE;		/* no error messages at the moment */
 }
+#endif
 
 /*
  * Same as emsg(...), but abort on error when ABORT_ON_INTERNAL_ERROR is
@@ -765,6 +767,7 @@
 #endif
 }
 
+#ifndef PROTO  // manual proto with __attribute__
 /*
  * Same as semsg(...) but abort on error when ABORT_ON_INTERNAL_ERROR is
  * defined. It is used for internal errors only, so that they can be
@@ -783,10 +786,11 @@
 	va_end(ap);
 	emsg_core(IObuff);
     }
-#ifdef ABORT_ON_INTERNAL_ERROR
+# ifdef ABORT_ON_INTERNAL_ERROR
     abort();
-#endif
+# endif
 }
+#endif
 
 /*
  * Give an "Internal error" message.

src/proto.h

diff --git a/src/proto.h b/src/proto.h
index 43192ff..4a5977f 100644
--- a/src/proto.h
+++ b/src/proto.h
@@ -134,6 +134,28 @@
 #endif
     ;
 
+/* These prototypes cannot be produced automatically. */
+int
+#  ifdef __BORLANDC__
+_RTLENTRYF
+#  endif
+semsg(const char *, ...)
+#ifdef USE_PRINTF_FORMAT_ATTRIBUTE
+    __attribute__((format(printf, 1, 0)))
+#endif
+    ;
+
+/* These prototypes cannot be produced automatically. */
+void
+#  ifdef __BORLANDC__
+_RTLENTRYF
+#  endif
+siemsg(const char *, ...)
+#ifdef USE_PRINTF_FORMAT_ATTRIBUTE
+    __attribute__((format(printf, 1, 0)))
+#endif
+    ;
+
 int
 #  ifdef __BORLANDC__
 _RTLENTRYF

src/proto/message.pro

diff --git a/src/proto/message.pro b/src/proto/message.pro
index 792ac5d..806de87 100644
--- a/src/proto/message.pro
+++ b/src/proto/message.pro
@@ -11,9 +11,7 @@
 void ignore_error_for_testing(char_u *error);
 void do_perror(char *msg);
 int emsg(char *s);
-int semsg(const char *s, ...);
 void iemsg(char *s);
-void siemsg(const char *s, ...);
 void internal_error(char *where);
 void emsg_invreg(int name);
 char *msg_trunc_attr(char *s, int force, int attr);

src/version.c

diff --git a/src/version.c b/src/version.c
index a266ce0..6fe4c9e 100644
--- a/src/version.c
+++ b/src/version.c
@@ -780,6 +780,8 @@
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    954,
+/**/
     953,
 /**/
     952,