commit 05a627c3d4e42a18f76c14828d68ee4747118211
author Bram Moolenaar <Bram@vim.org> Sun Apr 09 22:01:31 2023 +0100
committer Bram Moolenaar <Bram@vim.org> Sun Apr 09 22:01:31 2023 +0100
tree 3178407812dcd3bdfb57ec78ce5eaffabf3a9eb3
parent bfc7cbd1d44e53e844a079d8ad16ae990dad664d

patch 9.0.1443: ending Insert mode when accessing a hidden prompt buffer

Problem:    Ending Insert mode when accessing a hidden prompt buffer.
Solution:   Don't stop Insert mode when it was active before. (closes #12237)

src/autocmd.c

diff --git a/src/autocmd.c b/src/autocmd.c
index e5f5125..6460fcd 100644
--- a/src/autocmd.c
+++ b/src/autocmd.c
@@ -1566,6 +1566,8 @@
     aco->save_curwin_id = curwin->w_id;
     aco->save_curbuf = curbuf;
     aco->save_prevwin_id = prevwin == NULL ? 0 : prevwin->w_id;
+    aco->save_State = State;
+
     if (win != NULL)
     {
 	// There is a window for "buf" in the current tab page, make it the
@@ -1660,6 +1662,9 @@
 #ifdef FEAT_JOB_CHANNEL
 	// May need to stop Insert mode if we were in a prompt buffer.
 	leaving_window(curwin);
+	// Do not stop Insert mode when already in Insert mode before.
+	if (aco->save_State & MODE_INSERT)
+	    stop_insert_mode = FALSE;
 #endif
 	// Remove the window and frame from the tree of frames.
 	(void)winframe_remove(curwin, &dummy, NULL);

src/structs.h

diff --git a/src/structs.h b/src/structs.h
index 39248a7..9500139 100644
--- a/src/structs.h
+++ b/src/structs.h
@@ -4274,6 +4274,7 @@
     bufref_T	new_curbuf;	    // new curbuf
     char_u	*globaldir;	    // saved value of globaldir
     int		save_VIsual_active; // saved VIsual_active
+    int		save_State;	    // saved State
 } aco_save_T;
 
 /*

src/testdir/test_prompt_buffer.vim

diff --git a/src/testdir/test_prompt_buffer.vim b/src/testdir/test_prompt_buffer.vim
index 28e0d76..b81309c 100644
--- a/src/testdir/test_prompt_buffer.vim
+++ b/src/testdir/test_prompt_buffer.vim
@@ -270,6 +270,7 @@
 
       func DoAppend()
         call appendbufline('prompt', '$', 'Test')
+        return ''
       endfunc
   END
   call writefile(script, 'XpromptBuffer', 'D')
@@ -282,11 +283,21 @@
 
   call term_sendkeys(buf, "exit\<CR>")
   call TermWait(buf)
+  call assert_notmatch('-- INSERT --', term_getline(buf, 10))
 
   call term_sendkeys(buf, ":call DoAppend()\<CR>")
   call TermWait(buf)
   call assert_notmatch('-- INSERT --', term_getline(buf, 10))
 
+  call term_sendkeys(buf, "i")
+  call TermWait(buf)
+  call assert_match('-- INSERT --', term_getline(buf, 10))
+
+  call term_sendkeys(buf, "\<C-R>=DoAppend()\<CR>")
+  call TermWait(buf)
+  call assert_match('-- INSERT --', term_getline(buf, 10))
+
+  call term_sendkeys(buf, "\<Esc>")
   call StopVimInTerminal(buf)
 endfunc
 

src/version.c

diff --git a/src/version.c b/src/version.c
index 192d582..eba3db4 100644
--- a/src/version.c
+++ b/src/version.c
@@ -696,6 +696,8 @@
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    1443,
+/**/
     1442,
 /**/
     1441,