commit 03afdcf1f449d23c9b6bc56d8b61f31dd4e11836
author Bram Moolenaar <Bram@vim.org> Mon Apr 27 23:39:30 2020 +0200
committer Bram Moolenaar <Bram@vim.org> Mon Apr 27 23:39:30 2020 +0200
tree d3ff3065c2501c7d38744725b56967ee03e05479
parent 909ed7e902d97054262fb55b28f5e855428ab7fe

patch 8.2.0653: using uninitialized pointer

Problem:    using uninitialized pointer.
Solution:   Move assignment up. (John Marriott)

src/testdir/test_vim9_script.vim

diff --git a/src/testdir/test_vim9_script.vim b/src/testdir/test_vim9_script.vim
index 0ab170e..4c821ec 100644
--- a/src/testdir/test_vim9_script.vim
+++ b/src/testdir/test_vim9_script.vim
@@ -707,8 +707,7 @@
       return valtwo
     enddef
   END
-  writefile(lines + morelines,
-            'Xreload.vim')
+  writefile(lines + morelines, 'Xreload.vim')
   source Xreload.vim
   source Xreload.vim
   source Xreload.vim
@@ -724,10 +723,9 @@
   writefile(testlines, 'Ximport.vim')
   source Ximport.vim
 
-  " test that when not using "morelines" valtwo is still defined
-  " need to source Xreload.vim again, import doesn't reload a script
+  " Test that when not using "morelines" GetValtwo() and valtwo are still
+  " defined, because import doesn't reload a script.
   writefile(lines, 'Xreload.vim')
-  source Xreload.vim
   source Ximport.vim
 
   " cannot declare a var twice
@@ -750,36 +748,36 @@
       return 'yes'
     enddef
   END
-  let middle_lines =<< trim END
+  let withno_lines =<< trim END
     def FuncNo(): string
       return 'no'
     enddef
-  END
-  let final_lines =<< trim END
     def g:DoCheck(no_exists: bool)
       assert_equal('yes', FuncYes())
-      if no_exists
-        assert_equal('no', FuncNo())
-      else
-        assert_fails('call FuncNo()', 'E117:')
-      endif
+      assert_equal('no', FuncNo())
+    enddef
+  END
+  let nono_lines =<< trim END
+    def g:DoCheck(no_exists: bool)
+      assert_equal('yes', FuncYes())
+      assert_fails('call FuncNo()', 'E117:')
     enddef
   END
 
   # FuncNo() is defined
-  writefile(first_lines + middle_lines + final_lines, 'Xreloaded.vim')
+  writefile(first_lines + withno_lines, 'Xreloaded.vim')
   source Xreloaded.vim
   g:DoCheck(true)
 
   # FuncNo() is not redefined
-  writefile(first_lines + final_lines, 'Xreloaded.vim')
+  writefile(first_lines + nono_lines, 'Xreloaded.vim')
   source Xreloaded.vim
-  g:DoCheck(false)
+  g:DoCheck()
 
   # FuncNo() is back
-  writefile(first_lines + middle_lines + final_lines, 'Xreloaded.vim')
+  writefile(first_lines + withno_lines, 'Xreloaded.vim')
   source Xreloaded.vim
-  g:DoCheck(true)
+  g:DoCheck()
 
   delete('Xreloaded.vim')
 enddef

src/userfunc.c

diff --git a/src/userfunc.c b/src/userfunc.c
index 86dea79..708b452 100644
--- a/src/userfunc.c
+++ b/src/userfunc.c
@@ -1599,9 +1599,9 @@
     for (hi = func_hashtab.ht_array; todo > 0; ++hi)
 	if (!HASHITEM_EMPTY(hi))
 	{
+	    fp = HI2UF(hi);
 	    if (STRNCMP(fp->uf_name, buf, len) == 0)
 	    {
-		fp = HI2UF(hi);
 		fp->uf_flags |= FC_DEAD;
 		func_clear(fp, TRUE);
 	    }

src/version.c

diff --git a/src/version.c b/src/version.c
index f9951e9..9bee513 100644
--- a/src/version.c
+++ b/src/version.c
@@ -747,6 +747,8 @@
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    653,
+/**/
     652,
 /**/
     651,