commit 00d253e2b2f435a5386582c3f857008e7ac355c2
author Bram Moolenaar <Bram@vim.org> Mon Apr 06 22:13:01 2020 +0200
committer Bram Moolenaar <Bram@vim.org> Mon Apr 06 22:13:01 2020 +0200
tree 71bbea4e4c6efa593a85266e445d82377a65f454
parent ee4e0c1e9a81cb5d96e0060203a9033c2f28588e

patch 8.2.0523: loops are repeated

Problem:    Loops are repeated.
Solution:   Use FOR_ALL_ macros. (Yegappan Lakshmanan, closes #5882)

src/menu.c

diff --git a/src/menu.c b/src/menu.c
index 0c88879..38b4fd8 100644
--- a/src/menu.c
+++ b/src/menu.c
@@ -1980,7 +1980,7 @@
 
     apply_autocmds(EVENT_MENUPOPUP, (char_u*)mode, NULL, FALSE, curbuf);
 
-    for (menu = root_menu; menu != NULL; menu = menu->next)
+    FOR_ALL_MENUS(menu)
 	if (STRNCMP("PopUp", menu->name, 5) == 0 && STRNCMP(menu->name + 5, mode, mode_len) == 0)
 	    break;
 
@@ -2133,7 +2133,7 @@
 
     if (key < 256)
 	key = TOLOWER_LOC(key);
-    for (menu = root_menu; menu != NULL; menu = menu->next)
+    FOR_ALL_MENUS(menu)
 	if (menu->mnemonic == key
 		|| (menu->mnemonic < 256 && TOLOWER_LOC(menu->mnemonic) == key))
 	    return TRUE;