commit 0044e5100a0e76a0bc1ea18c63a432c20428de5e
author LemonBoy <thatlemon@gmail.com> Wed Apr 20 19:47:37 2022 +0100
committer Bram Moolenaar <Bram@vim.org> Wed Apr 20 19:47:37 2022 +0100
tree e3ad4e3fdeb6ec2997ec5b061b72410abefaa697
parent dbec26d7893dca4ff38fa4b96ac91203d30ccae5

patch 8.2.4799: popup does not use correct topline

Problem:    Popup does not use correct topline.
Solution:   Also add one when firstline is negative. (closes #10229)

src/popupwin.c

diff --git a/src/popupwin.c b/src/popupwin.c
index e6792c8..27e9fe1 100644
--- a/src/popupwin.c
+++ b/src/popupwin.c
@@ -1414,7 +1414,7 @@
     }
 
     if (wp->w_firstline < 0)
-	wp->w_topline = lnum > 0 ? lnum + 1 : lnum;
+	wp->w_topline = lnum + 1;
 
     wp->w_has_scrollbar = wp->w_want_scrollbar
 	   && (wp->w_topline > 1 || lnum <= wp->w_buffer->b_ml.ml_line_count);

src/testdir/test_popupwin.vim

diff --git a/src/testdir/test_popupwin.vim b/src/testdir/test_popupwin.vim
index b91689e..3e5373c 100644
--- a/src/testdir/test_popupwin.vim
+++ b/src/testdir/test_popupwin.vim
@@ -514,6 +514,19 @@
   call assert_equal(5, popup_getpos(winid).firstline)
 
   call popup_close(winid)
+
+  " Popup with less elements than the maximum height and negative firstline:
+  " check that the popup height is correctly computed.
+  let winid = popup_create(['xxx']->repeat(4), #{
+        \ firstline: -1,
+        \ maxheight: 6,
+	\ })
+
+  let pos = popup_getpos(winid)
+  call assert_equal(3, pos.width)
+  call assert_equal(4, pos.height)
+
+  call popup_close(winid)
 endfunc
 
 func Test_popup_firstline_cursorline()

src/version.c

diff --git a/src/version.c b/src/version.c
index 83d8e1b..447bbd8 100644
--- a/src/version.c
+++ b/src/version.c
@@ -747,6 +747,8 @@
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    4799,
+/**/
     4798,
 /**/
     4797,