commit f523ee14c68e775dcb1cdd2822629b6b29c7a4ef
author Peter Åstrand (astrand) <astrand@cendio.se> Mon Oct 09 14:59:24 2017 +0200
committer Peter Åstrand (astrand) <astrand@cendio.se> Tue Nov 07 11:05:34 2017 +0100
tree 3166068d8534598f2f8ba53900afd03e0a78c43d
parent daba227da64b488a264417708e91e285aeb2fa54

Using namespace rfb in header files is a bad idea

unix/x0vncserver/PollingManager.h

diff --git a/unix/x0vncserver/PollingManager.h b/unix/x0vncserver/PollingManager.h
index e106f79..5025fa5 100644
--- a/unix/x0vncserver/PollingManager.h
+++ b/unix/x0vncserver/PollingManager.h
@@ -32,8 +32,6 @@
 #include <x0vncserver/TimeMillis.h>
 #endif
 
-using namespace rfb;
-
 class PollingManager {
 
 public:
@@ -42,12 +40,12 @@
                  int offsetLeft = 0, int offsetTop = 0);
   virtual ~PollingManager();
 
-  void poll(VNCServer *server);
+  void poll(rfb::VNCServer *server);
 
 protected:
 
   // Screen polling. Returns true if some changes were detected.
-  bool pollScreen(VNCServer *server);
+  bool pollScreen(rfb::VNCServer *server);
 
   Display *m_dpy;
 
@@ -85,7 +83,7 @@
 
   int checkRow(int x, int y, int w);
   int checkColumn(int x, int y, int h, bool *pChangeFlags);
-  int sendChanges(VNCServer *server) const;
+  int sendChanges(rfb::VNCServer *server) const;
 
   // Check neighboring tiles and update m_changeFlags[].
   void checkNeighbors();