commit f523ee14c68e775dcb1cdd2822629b6b29c7a4ef
author Peter Åstrand (astrand) <astrand@cendio.se> Mon Oct 09 14:59:24 2017 +0200
committer Peter Åstrand (astrand) <astrand@cendio.se> Tue Nov 07 11:05:34 2017 +0100
tree 3166068d8534598f2f8ba53900afd03e0a78c43d
parent daba227da64b488a264417708e91e285aeb2fa54

Using namespace rfb in header files is a bad idea

unix/x0vncserver/Geometry.h

diff --git a/unix/x0vncserver/Geometry.h b/unix/x0vncserver/Geometry.h
index 9caeeba..98bafb2 100644
--- a/unix/x0vncserver/Geometry.h
+++ b/unix/x0vncserver/Geometry.h
@@ -26,8 +26,6 @@
 #include <rfb/Rect.h>
 #include <rfb/Configuration.h>
 
-using namespace rfb;
-
 class Geometry
 {
 public:
@@ -43,18 +41,18 @@
   int offsetTop() const { return m_rect.tl.y; }
 
   // Return the same information as a Rect structure.
-  const Rect& getRect() const { return m_rect; }
+  const rfb::Rect& getRect() const { return m_rect; }
 
 protected:
   // Parse a string, extract size and coordinates,
   // and return that rectangle clipped to m_rect.
-  Rect parseString(const char *arg) const;
+  rfb::Rect parseString(const char *arg) const;
 
-  static StringParameter m_geometryParam;
+  static rfb::StringParameter m_geometryParam;
 
   int m_fullWidth;
   int m_fullHeight;
-  Rect m_rect;
+  rfb::Rect m_rect;
 };
 
 #endif // __GEOMETRY_H__