commit a7bbe9c4a3b2090240173e45bebab86e5cba3b4b
author Pierre Ossman <ossman@cendio.se> Tue Mar 03 16:17:51 2015 +0100
committer Pierre Ossman <ossman@cendio.se> Tue Mar 03 16:17:51 2015 +0100
tree 0bdba695d5126806843d24245ff20b3b16f3a27a
parent 5b3c5f49b103d45ce11cd7c0319c82b95ee61e58

Make sure Exceptions do not use unsafe format strings

common/rdr/TLSException.cxx

diff --git a/common/rdr/TLSException.cxx b/common/rdr/TLSException.cxx
index 3d39d79..bf8e97a 100644
--- a/common/rdr/TLSException.cxx
+++ b/common/rdr/TLSException.cxx
@@ -34,15 +34,8 @@
 
 #ifdef HAVE_GNUTLS
 TLSException::TLSException(const char* s, int err_)
-  : Exception(s), err(err_)
+  : Exception("%s: %s (%d)", s, gnutls_strerror(err), err), err(err_)
 {
-  strncat(str_, ": ", len-1-strlen(str_));
-  strncat(str_, gnutls_strerror(err), len-1-strlen(str_));
-  strncat(str_, " (", len-1-strlen(str_));
-  char buf[20];
-  sprintf(buf,"%d",err);
-  strncat(str_, buf, len-1-strlen(str_));
-  strncat(str_, ")", len-1-strlen(str_));
 }
 #endif /* HAVE_GNUTLS */