| commit | 8ee522a66e6d25aa1b89acb8a28c53cb63f781e5 | [log] [tgz] |
|---|---|---|
| author | Pierre Ossman <ossman@cendio.se> | Tue May 29 15:50:08 2018 +0200 |
| committer | Pierre Ossman <ossman@cendio.se> | Tue May 29 15:50:08 2018 +0200 |
| tree | 2df3e9bd238ba6b1bc34a887e0f800ce80c7e0d4 | |
| parent | 8750db35e8d2792b6d2063ccfc439c2854edd593 [diff] [blame] |
Catch exceptions by reference We use polymorphic exception objects, so catching by value invokes the copy constructor and stuff that we don't really want.
diff --git a/win/rfb_win32/Dialog.cxx b/win/rfb_win32/Dialog.cxx index c6f303c..c9e333d 100644 --- a/win/rfb_win32/Dialog.cxx +++ b/win/rfb_win32/Dialog.cxx
@@ -344,7 +344,7 @@ delete [] hpages; hpages = 0; return true; - } catch (rdr::Exception) { + } catch (rdr::Exception&) { alreadyShowing = false; std::list<PropSheetPage*>::iterator pspi;