commit 8ee522a66e6d25aa1b89acb8a28c53cb63f781e5
author Pierre Ossman <ossman@cendio.se> Tue May 29 15:50:08 2018 +0200
committer Pierre Ossman <ossman@cendio.se> Tue May 29 15:50:08 2018 +0200
tree 2df3e9bd238ba6b1bc34a887e0f800ce80c7e0d4
parent 8750db35e8d2792b6d2063ccfc439c2854edd593

Catch exceptions by reference

We use polymorphic exception objects, so catching by value invokes
the copy constructor and stuff that we don't really want.

common/rfb/DecodeManager.cxx

diff --git a/common/rfb/DecodeManager.cxx b/common/rfb/DecodeManager.cxx
index 774f7bb..c509db0 100644
--- a/common/rfb/DecodeManager.cxx
+++ b/common/rfb/DecodeManager.cxx
@@ -277,7 +277,7 @@
       entry->decoder->decodeRect(entry->rect, entry->bufferStream->data(),
                                  entry->bufferStream->length(),
                                  *entry->cp, entry->pb);
-    } catch (rdr::Exception e) {
+    } catch (rdr::Exception& e) {
       manager->setThreadException(e);
     } catch(...) {
       assert(false);

common/rfb/HTTPServer.cxx

diff --git a/common/rfb/HTTPServer.cxx b/common/rfb/HTTPServer.cxx
index 54becbb..2895a69 100644
--- a/common/rfb/HTTPServer.cxx
+++ b/common/rfb/HTTPServer.cxx
@@ -125,7 +125,7 @@
     while (1) {
       os.writeU8(is.readU8());
     }
-  } catch (rdr::EndOfStream) {
+  } catch (rdr::EndOfStream&) {
   }
 }