commit 851e6806e585090b50bbf8b8283f6acca195c390
author Pierre Ossman <ossman@cendio.se> Tue Sep 12 16:44:44 2017 +0200
committer Pierre Ossman <ossman@cendio.se> Fri Sep 15 11:18:42 2017 +0200
tree 3cd488eb4eb33e34150f66c7c7b22cf354f4627f
parent 63cc07e800b12f6a1448ed7775f42ecec9d08fbc

Fix shift state test in lock key heuristics

common/rfb/VNCSConnectionST.cxx

diff --git a/common/rfb/VNCSConnectionST.cxx b/common/rfb/VNCSConnectionST.cxx
index cf37fdd..b183c05 100644
--- a/common/rfb/VNCSConnectionST.cxx
+++ b/common/rfb/VNCSConnectionST.cxx
@@ -615,8 +615,7 @@
         bool uppercase, shift, lock;
 
         uppercase = (keysym >= XK_A) && (keysym <= XK_Z);
-        shift = pressedKeys.find(XK_Shift_L) != pressedKeys.end() ||
-                pressedKeys.find(XK_Shift_R) != pressedKeys.end();
+        shift = isShiftPressed();
         lock = server->ledState & ledCapsLock;
 
         if (lock == (uppercase == shift)) {
@@ -636,8 +635,7 @@
 
         number = ((keysym >= XK_KP_0) && (keysym <= XK_KP_9)) ||
                   (keysym == XK_KP_Separator) || (keysym == XK_KP_Decimal);
-        shift = pressedKeys.find(XK_Shift_L) != pressedKeys.end() ||
-                pressedKeys.find(XK_Shift_R) != pressedKeys.end();
+        shift = isShiftPressed();
         lock = server->ledState & ledNumLock;
 
         if (shift) {
@@ -662,21 +660,8 @@
   // Turn ISO_Left_Tab into shifted Tab.
   VNCSConnectionSTShiftPresser shiftPresser(server->desktop);
   if (keysym == XK_ISO_Left_Tab) {
-    std::map<rdr::U32, rdr::U32>::const_iterator iter;
-    bool shifted;
-
-    shifted = false;
-    for (iter = pressedKeys.begin(); iter != pressedKeys.end(); ++iter) {
-      if ((iter->second == XK_Shift_L) ||
-          (iter->second == XK_Shift_R)) {
-        shifted = true;
-        break;
-      }
-    }
-
-    if (!shifted)
+    if (!isShiftPressed())
       shiftPresser.press();
-
     keysym = XK_Tab;
   }
 
@@ -896,6 +881,19 @@
   return false;
 }
 
+bool VNCSConnectionST::isShiftPressed()
+{
+    std::map<rdr::U32, rdr::U32>::const_iterator iter;
+
+    for (iter = pressedKeys.begin(); iter != pressedKeys.end(); ++iter) {
+      if (iter->second == XK_Shift_L)
+        return true;
+      if (iter->second == XK_Shift_R)
+        return true;
+    }
+
+  return false;
+}
 
 void VNCSConnectionST::writeRTTPing()
 {

common/rfb/VNCSConnectionST.h

diff --git a/common/rfb/VNCSConnectionST.h b/common/rfb/VNCSConnectionST.h
index d3bec93..9b7b14b 100644
--- a/common/rfb/VNCSConnectionST.h
+++ b/common/rfb/VNCSConnectionST.h
@@ -160,6 +160,8 @@
 
     // Internal methods
 
+    bool isShiftPressed();
+
     // Congestion control
     void writeRTTPing();
     void handleRTTPong(const struct RTTInfo &rttInfo);