commit 7f8f3ea2c4349bd78f2c2279c4d04a9505fddf64
author Pierre Ossman <ossman@cendio.se> Tue Oct 21 16:29:05 2014 +0200
committer Pierre Ossman <ossman@cendio.se> Tue Oct 21 16:29:05 2014 +0200
tree b3ac077435d4f5a6c7cfe099bb85557672a6554e
parent b9203b9342edcf8b209830576aee31f0445ee6fd
parent f95272de303373b3d2d55e001a0dac9a8d800407

Merge branch 'build' of https://github.com/CendioOssman/tigervnc

vncviewer/X11PixelBuffer.cxx

diff --git a/vncviewer/X11PixelBuffer.cxx b/vncviewer/X11PixelBuffer.cxx
index 59b90e2..a779427 100644
--- a/vncviewer/X11PixelBuffer.cxx
+++ b/vncviewer/X11PixelBuffer.cxx
@@ -156,6 +156,11 @@
   Bool pixmaps;
   XErrorHandler old_handler;
   Status status;
+  const char *display_name = XDisplayName (NULL);
+
+  /* Don't use MIT-SHM on remote displays */
+  if (*display_name && *display_name != ':')
+    return 0;
 
   if (!XShmQueryVersion(fl_display, &major, &minor, &pixmaps))
     return 0;
@@ -184,7 +189,11 @@
   caughtError = false;
   old_handler = XSetErrorHandler(XShmAttachErrorHandler);
 
-  XShmAttach(fl_display, shminfo);
+  if (!XShmAttach(fl_display, shminfo)) {
+    XSetErrorHandler(old_handler);
+    goto free_shmaddr;
+  }
+
   XSync(fl_display, False);
 
   XSetErrorHandler(old_handler);