blob: ea9e85bf7c636e855eb87cd5b382e48df020f28d [file] [log] [blame]
Roman Stratiienkocef5c772021-12-22 16:22:24 +02001
2INCLUDE_DIRS := . ../libdrm/include/drm include ./.ci/android_headers ./tests/test_include
3SYSTEM_INCLUDE_DIRS := /usr/include/libdrm
4
Roman Stratiienkoa7913de2022-10-20 13:18:57 +03005CLANG := clang++-15
6CLANG_TIDY := clang-tidy-15
Roman Stratiienko5741bbd2021-12-30 18:12:26 +02007OUT_DIR := /tmp/drm_hwcomposer/build
Roman Stratiienkocef5c772021-12-22 16:22:24 +02008SRC_DIR := .
9
10CXXFLAGS := -fPIC -Wall -Wextra -Werror -DPLATFORM_SDK_VERSION=31 -D__ANDROID_API__=31
11CXXFLAGS += -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS
12CXXFLAGS += -fvisibility-inlines-hidden -std=gnu++17 -DHWC2_USE_CPP11 -DHWC2_INCLUDE_STRINGIFICATION -fno-rtti
13
Roman Stratiienko5741bbd2021-12-30 18:12:26 +020014SKIP_FILES := \
15 bufferinfo/BufferInfoMapperMetadata.cpp
Roman Stratiienkocef5c772021-12-22 16:22:24 +020016
Roman Stratiienko5741bbd2021-12-30 18:12:26 +020017TIDY_FILES_OVERRIDE := \
Roman Stratiienko5741bbd2021-12-30 18:12:26 +020018 bufferinfo/legacy/BufferInfoImagination.cpp:COARSE \
19 bufferinfo/legacy/BufferInfoLibdrm.cpp:COARSE \
20 bufferinfo/legacy/BufferInfoMaliHisi.cpp:COARSE \
21 bufferinfo/legacy/BufferInfoMaliMediatek.cpp:COARSE \
22 bufferinfo/legacy/BufferInfoMaliMeson.cpp:COARSE \
23 bufferinfo/legacy/BufferInfoMinigbm.cpp:COARSE \
Roman Stratiienko5741bbd2021-12-30 18:12:26 +020024 drm/DrmFbImporter.h:FINE \
Roman Stratiienko5741bbd2021-12-30 18:12:26 +020025 drm/DrmUnique.h:FINE \
Roman Stratiienko5741bbd2021-12-30 18:12:26 +020026 drm/VSyncWorker.cpp:COARSE \
Roman Stratiienko3e168902022-01-04 16:13:12 +020027 hwc2_device/DrmHwcTwo.cpp:COARSE \
28 hwc2_device/DrmHwcTwo.h:COARSE \
Roman Stratiienko3627beb2022-01-04 16:02:55 +020029 hwc2_device/HwcDisplay.cpp:COARSE \
30 hwc2_device/HwcDisplay.h:COARSE \
Roman Stratiienko5741bbd2021-12-30 18:12:26 +020031 tests/worker_test.cpp:COARSE \
32 utils/Worker.h:COARSE \
33 utils/UniqueFd.h:FINE \
34 utils/log.h:FINE \
35 utils/properties.h:FINE \
Roman Stratiienkocef5c772021-12-22 16:22:24 +020036
Roman Stratiienkoc46896d2022-01-04 11:10:22 +020037TIDY_CHECKS_FINE := * \
38 -llvmlibc* -fuchsia-* -altera-* \
39 -llvm-header-guard \
40 -cppcoreguidelines-pro-type-vararg \
41 -hicpp-vararg \
42 -hicpp-signed-bitwise \
Roman Stratiienkocf80b9b2022-04-28 15:42:36 +030043 -readability-identifier-length \
Roman Stratiienkoc46896d2022-01-04 11:10:22 +020044
45TIDY_CHECKS_NORMAL := \
46 $(TIDY_CHECKS_FINE) \
47 -hicpp* \
Roman Stratiienko780f7da2022-01-10 16:04:15 +020048 -bugprone-easily-swappable-parameters \
Roman Stratiienko24a7fc42021-12-23 16:25:20 +020049 -cppcoreguidelines-special-member-functions \
Roman Stratiienko24a7fc42021-12-23 16:25:20 +020050 -cppcoreguidelines-avoid-c-arrays \
Roman Stratiienkofc014f52021-12-23 19:04:29 +020051 -cppcoreguidelines-pro-bounds-array-to-pointer-decay \
52 -cppcoreguidelines-pro-bounds-constant-array-index \
53 -cppcoreguidelines-avoid-magic-numbers \
Roman Stratiienko24a7fc42021-12-23 16:25:20 +020054 -google-readability-braces-around-statements \
55 -google-readability-casting \
56 -misc-non-private-member-variables-in-classes \
57 -modernize-avoid-c-arrays \
Roman Stratiienkofc014f52021-12-23 19:04:29 +020058 -modernize-use-nodiscard \
Roman Stratiienko24a7fc42021-12-23 16:25:20 +020059 -modernize-use-trailing-return-type \
60 -readability-braces-around-statements \
Roman Stratiienko24a7fc42021-12-23 16:25:20 +020061
62TIDY_CHECKS_COARSE := \
63 $(TIDY_CHECKS_NORMAL) \
Roman Stratiienkoe78235c2021-12-23 17:36:12 +020064 -cppcoreguidelines-non-private-member-variables-in-classes \
Roman Stratiienkocef5c772021-12-22 16:22:24 +020065 -cppcoreguidelines-pro-bounds-pointer-arithmetic \
66 -cppcoreguidelines-pro-type-cstyle-cast \
Roman Stratiienkoe78235c2021-12-23 17:36:12 +020067 -cppcoreguidelines-pro-type-reinterpret-cast \
68 -cppcoreguidelines-pro-type-static-cast-downcast \
Roman Stratiienkocef5c772021-12-22 16:22:24 +020069 -cppcoreguidelines-pro-type-union-access \
Roman Stratiienkocef5c772021-12-22 16:22:24 +020070 -cppcoreguidelines-macro-usage \
Roman Stratiienkocef5c772021-12-22 16:22:24 +020071 -readability-convert-member-functions-to-static \
72 -readability-implicit-bool-conversion \
73 -readability-identifier-naming \
74 -readability-magic-numbers \
Roman Stratiienkocef5c772021-12-22 16:22:24 +020075
Roman Stratiienko5741bbd2021-12-30 18:12:26 +020076.PHONY: all build tidy clean
Roman Stratiienko24a7fc42021-12-23 16:25:20 +020077
Roman Stratiienko5741bbd2021-12-30 18:12:26 +020078all: build tidy
Roman Stratiienkocef5c772021-12-22 16:22:24 +020079
80clean:
81 rm -rf $(OUT_DIR)/
82
Roman Stratiienko5741bbd2021-12-30 18:12:26 +020083# Build
84
Roman Stratiienkobd973172022-02-18 16:51:53 +020085BUILD_FILES_AUTO := $(shell find -L $(SRC_DIR) -not -path '*/\.*' -not -path '*/tests/test_include/*' -path '*.cpp')
Roman Stratiienko5741bbd2021-12-30 18:12:26 +020086SKIP_FILES_path := $(foreach file,$(SKIP_FILES),$(SRC_DIR)/$(file))
87
88BUILD_FILES := $(subst ./,,$(filter-out $(SKIP_FILES_path),$(BUILD_FILES_AUTO)))
89
Roman Stratiienkocef5c772021-12-22 16:22:24 +020090_OBJ := $(BUILD_FILES:.cpp=.o)
91OBJ := $(patsubst %,$(OUT_DIR)/%,$(_OBJ))
92
Roman Stratiienkocef5c772021-12-22 16:22:24 +020093DEPS := $(patsubst %.cpp,$(OUT_DIR)/%.d,$(BUILD_FILES))
94
95build: $(OBJ)
96
Roman Stratiienkocef5c772021-12-22 16:22:24 +020097CXXARGS := $(foreach dir,$(INCLUDE_DIRS),-I$(SRC_DIR)/$(dir)) $(foreach dir,$(SYSTEM_INCLUDE_DIRS),-I$(dir)) $(CXXFLAGS)
98
99$(OUT_DIR)/%.o: $(SRC_DIR)/%.cpp
100 mkdir -p $(dir $@)
101 $(CLANG) $< $(CXXARGS) -c -o $@
102
103$(OUT_DIR)/%.d: $(SRC_DIR)/%.cpp
104 mkdir -p $(dir $@)
Roman Stratiienko35112732021-12-23 13:41:13 +0200105 $(CLANG) $(CXXARGS) $< -MM -MT $(OUT_DIR)/$(patsubst %.cpp,%.o,$<) -o $@
Roman Stratiienkocef5c772021-12-22 16:22:24 +0200106
Roman Stratiienko24a7fc42021-12-23 16:25:20 +0200107# TIDY
Roman Stratiienkobd973172022-02-18 16:51:53 +0200108TIDY_FILES_AUTO := $(shell find -L $(SRC_DIR) -not -path '*/\.*' -not -path '*/tests/test_include/*' \( -path '*.cpp' -o -path '*.h' \))
Roman Stratiienko5741bbd2021-12-30 18:12:26 +0200109
110TIDY_FILES_AUTO_filtered := $(filter-out $(SKIP_FILES_path),$(TIDY_FILES_AUTO))
111
112TIDY_FILES_OVERRIDE_path := $(foreach pair,$(TIDY_FILES_OVERRIDE),$(SRC_DIR)/$(pair))
113
114TIDY_FILES_OVERRIDE_name_only := $(foreach pair,$(TIDY_FILES_OVERRIDE_path),$(word 1, $(subst :, ,$(pair))))
115
116TIDY_FILES := $(sort $(TIDY_FILES_AUTO_filtered) $(TIDY_FILES_OVERRIDE_name_only))
117
Roman Stratiienkocef5c772021-12-22 16:22:24 +0200118space := $(subst ,, )
119comma := ,
120
Roman Stratiienko24a7fc42021-12-23 16:25:20 +0200121TIDY_ARGS_NONE := --checks="-*,llvm-include-order"
122TIDY_ARGS_ := --checks="-*,llvm-include-order"
Roman Stratiienkoc46896d2022-01-04 11:10:22 +0200123TIDY_ARGS_FINE := --checks="$(subst $(space),$(comma),$(strip $(TIDY_CHECKS_FINE)))"
Roman Stratiienko24a7fc42021-12-23 16:25:20 +0200124TIDY_ARGS_NORMAL := --checks="$(subst $(space),$(comma),$(strip $(TIDY_CHECKS_NORMAL)))"
125TIDY_ARGS_COARSE := --checks="$(subst $(space),$(comma),$(strip $(TIDY_CHECKS_COARSE)))"
126
127define process-tidy
128
129_TARG := $(OUT_DIR)/$1.tidy.ts
130_DEP := $(SRC_DIR)/$1
131
132TIDY_DEPS += $(_TARG)
133
Roman Stratiienko5741bbd2021-12-30 18:12:26 +0200134TIDY_LEVEL_1 := $$(strip $$(foreach pair,$$(TIDY_FILES_OVERRIDE_path),$$(if $$(filter $$(word 1, $$(subst :, ,$$(pair))),$1),$$(word 2, $$(subst :, ,$$(pair))),)))
Roman Stratiienko24a7fc42021-12-23 16:25:20 +0200135
Roman Stratiienko5741bbd2021-12-30 18:12:26 +0200136TIDY_LEVEL_2 := $$(if $$(TIDY_LEVEL_1),$$(TIDY_LEVEL_1),NORMAL)
137
138TIDY_ARGS := $$(TIDY_ARGS_$$(TIDY_LEVEL_2))
139
140$$(_TARG): _DEP := $$(_DEP)
141$$(_TARG): _TARG := $$(_TARG)
142$$(_TARG): TIDY_ARGS := $$(TIDY_ARGS)
143$$(_TARG): $$(_DEP)
144 mkdir -p $$(dir $$(_TARG))
Roman Stratiienkobd973172022-02-18 16:51:53 +0200145 $$(CLANG_TIDY) $$(_DEP) $$(TIDY_ARGS) -- -x c++ $$(CXXARGS) -Wno-pragma-once-outside-header
Roman Stratiienko5741bbd2021-12-30 18:12:26 +0200146 touch $$(_TARG)
Roman Stratiienko24a7fc42021-12-23 16:25:20 +0200147
Roman Stratiienkocef5c772021-12-22 16:22:24 +0200148endef
149
Roman Stratiienko5741bbd2021-12-30 18:12:26 +0200150$(foreach file,$(TIDY_FILES),$(eval $(call process-tidy,$(file))))
Roman Stratiienkocef5c772021-12-22 16:22:24 +0200151
Roman Stratiienko24a7fc42021-12-23 16:25:20 +0200152tidy: $(TIDY_DEPS)
Roman Stratiienkocef5c772021-12-22 16:22:24 +0200153
154ifneq ($(MAKECMDGOALS), clean)
155-include $(DEPS)
156endif