| commit | cfc2b2e60267fb4140e99c0049598752c7d8749a | [log] [tgz] |
|---|---|---|
| author | Roman Stratiienko <r.stratiienko@gmail.com> | Tue Sep 01 13:39:17 2020 +0300 |
| committer | Roman Stratiienko <r.stratiienko@gmail.com> | Tue Sep 01 23:12:47 2020 +0300 |
| tree | 13d76eba6f4ce05bb602301240ba8d5c01f955f4 | |
| parent | 51a0e0d30cfbcbf869c44650b33da08585bb6fab [diff] |
drm_hwcomposer: fix incorrect layer_count usage According to [1] DRM YCrCb planes is not the same as gralloc layers. DRMHWC2 has no information about number of layers used in the buffer. Also supplying value other than 1 will allways fail validation on passthrough MapperHal@2.1 and probably other passthrough implementations [2]. [1] - https://cs.android.com/android/platform/superproject/+/master:hardware/libhardware/include/hardware/gralloc1.h;l=467;drc=1155c41d016a118801fe97b55af9918e531f7f84 [2] - https://cs.android.com/android/platform/superproject/+/master:hardware/interfaces/graphics/mapper/2.1/utils/passthrough/include/mapper-passthrough/2.1/Gralloc0Hal.h;l=40;drc=e308ceb1e9940d1d90a11177782a7cfe8630bb95 Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com> Change-Id: Idbfea8eaa74a557b98ecdff728e6c67aeea9cea6
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
Submit changes via gitlab merge requests on gitlab.freedesktop.org
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
`git diff | clang-format-diff-5.0 -p 1 -style=file`
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues
Happy hacking!