| commit | 5983318f173039d813d2a7c7104cd574d844aadf | [log] [tgz] |
|---|---|---|
| author | Drew Davenport <ddavenport@google.com> | Fri Dec 13 10:02:15 2024 -0700 |
| committer | Drew Davenport <ddavenport@google.com> | Mon Dec 16 17:01:49 2024 -0700 |
| tree | 3aa1a255deeaa573d6dee349c0ff10a597b91be9 | |
| parent | 0bc3df0be269a8d16e0e39c9cfae3068343ea0c9 [diff] |
drm_hwcomposer: Set vsync period for vsync thread Make HwcDisplay set the VsyncWorker's vsync_period whenever it changes, rather than having VsyncWorker query the vsync_period from HwcDisplay. Doing so prevents the VsyncWorker thread from needing to acquire the global lock to read HwcDisplay's state. The original change called GetVsyncPeriod, which checks the vsync period for the mode that is currently committed to the kernel based on HwcDisplay::configs_.active_config_id, so call VsyncWorker::SetVsyncPeriod whenever active_config_id is set. Change-Id: Ie301c47e2496748117db8cca8a6ee9691e723c74 Signed-off-by: Drew Davenport <ddavenport@google.com>
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms. So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
Submit changes via gitlab merge requests on gitlab.freedesktop.org.
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/.
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
git diff | clang-format-diff-19 -p 1 -style=file
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues.
Happy hacking!