drm_hwcomposer: CI: Raise clang-tidy level from NONE to COARSE for *.h
To improve CI coverage.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
diff --git a/drm/DrmConnector.h b/drm/DrmConnector.h
index f2305aa..2bcb543 100644
--- a/drm/DrmConnector.h
+++ b/drm/DrmConnector.h
@@ -17,9 +17,9 @@
#ifndef ANDROID_DRM_CONNECTOR_H_
#define ANDROID_DRM_CONNECTOR_H_
-#include <stdint.h>
#include <xf86drmMode.h>
+#include <cstdint>
#include <string>
#include <vector>
diff --git a/drm/DrmCrtc.h b/drm/DrmCrtc.h
index 7972bef..85e067a 100644
--- a/drm/DrmCrtc.h
+++ b/drm/DrmCrtc.h
@@ -17,9 +17,10 @@
#ifndef ANDROID_DRM_CRTC_H_
#define ANDROID_DRM_CRTC_H_
-#include <stdint.h>
#include <xf86drmMode.h>
+#include <cstdint>
+
#include "DrmMode.h"
#include "DrmProperty.h"
diff --git a/drm/DrmDevice.h b/drm/DrmDevice.h
index 4cbbd60..b5508af 100644
--- a/drm/DrmDevice.h
+++ b/drm/DrmDevice.h
@@ -17,8 +17,7 @@
#ifndef ANDROID_DRM_H_
#define ANDROID_DRM_H_
-#include <stdint.h>
-
+#include <cstdint>
#include <map>
#include <tuple>
@@ -86,7 +85,7 @@
}
DrmFbImporter &GetDrmFbImporter() {
- return *mDrmFbImporter.get();
+ return *mDrmFbImporter;
}
static auto IsKMSDev(const char *path) -> bool;
diff --git a/drm/DrmEncoder.h b/drm/DrmEncoder.h
index 4c01bc1..b130b7d 100644
--- a/drm/DrmEncoder.h
+++ b/drm/DrmEncoder.h
@@ -17,9 +17,9 @@
#ifndef ANDROID_DRM_ENCODER_H_
#define ANDROID_DRM_ENCODER_H_
-#include <stdint.h>
#include <xf86drmMode.h>
+#include <cstdint>
#include <set>
#include <vector>
diff --git a/drm/DrmMode.h b/drm/DrmMode.h
index 41b9e15..20515f9 100644
--- a/drm/DrmMode.h
+++ b/drm/DrmMode.h
@@ -17,10 +17,10 @@
#ifndef ANDROID_DRM_MODE_H_
#define ANDROID_DRM_MODE_H_
-#include <stdio.h>
#include <xf86drmMode.h>
#include <cstdint>
+#include <cstdio>
#include <string>
#include "DrmUnique.h"
@@ -32,7 +32,7 @@
class DrmMode {
public:
DrmMode() = default;
- DrmMode(drmModeModeInfoPtr m);
+ explicit DrmMode(drmModeModeInfoPtr m);
bool operator==(const drmModeModeInfo &m) const;
diff --git a/drm/DrmPlane.h b/drm/DrmPlane.h
index 7fab2ba..6487776 100644
--- a/drm/DrmPlane.h
+++ b/drm/DrmPlane.h
@@ -17,9 +17,9 @@
#ifndef ANDROID_DRM_PLANE_H_
#define ANDROID_DRM_PLANE_H_
-#include <stdint.h>
#include <xf86drmMode.h>
+#include <cstdint>
#include <vector>
#include "DrmCrtc.h"
diff --git a/drm/DrmProperty.h b/drm/DrmProperty.h
index 68f300f..26a7c38 100644
--- a/drm/DrmProperty.h
+++ b/drm/DrmProperty.h
@@ -17,9 +17,9 @@
#ifndef ANDROID_DRM_PROPERTY_H_
#define ANDROID_DRM_PROPERTY_H_
-#include <stdint.h>
#include <xf86drmMode.h>
+#include <cstdint>
#include <map>
#include <string>
#include <vector>
@@ -62,14 +62,14 @@
auto AddEnumToMap(const std::string &name, E key, std::map<E, uint64_t> &map)
-> bool;
- operator bool() const {
+ explicit operator bool() const {
return id_ != 0;
}
private:
class DrmPropertyEnum {
public:
- DrmPropertyEnum(drm_mode_property_enum *e);
+ explicit DrmPropertyEnum(drm_mode_property_enum *e);
~DrmPropertyEnum() = default;
uint64_t value_;
diff --git a/drm/ResourceManager.h b/drm/ResourceManager.h
index bb91882..b02bf36 100644
--- a/drm/ResourceManager.h
+++ b/drm/ResourceManager.h
@@ -17,7 +17,7 @@
#ifndef RESOURCEMANAGER_H
#define RESOURCEMANAGER_H
-#include <string.h>
+#include <cstring>
#include "DrmDevice.h"
#include "DrmFbImporter.h"
@@ -40,7 +40,7 @@
int getDisplayCount() const {
return num_displays_;
}
- bool ForcedScalingWithGpu() {
+ bool ForcedScalingWithGpu() const {
return scale_with_gpu_;
}
diff --git a/drm/VSyncWorker.h b/drm/VSyncWorker.h
index 74ff487..67aaa16 100644
--- a/drm/VSyncWorker.h
+++ b/drm/VSyncWorker.h
@@ -20,9 +20,9 @@
#include <hardware/hardware.h>
#include <hardware/hwcomposer.h>
#include <hardware/hwcomposer2.h>
-#include <stdint.h>
#include <atomic>
+#include <cstdint>
#include <functional>
#include <map>