commit e78235c0be19778ff25839ab8bedc0d06fc8b7ad
author Roman Stratiienko <roman.o.stratiienko@globallogic.com> Thu Dec 23 17:36:12 2021 +0200
committer Roman Stratiienko <roman.o.stratiienko@globallogic.com> Wed Jan 12 10:33:55 2022 +0200
tree 2af2de9cc114feb055867a68d75687209da1e658
parent 24a7fc43eb610f531394d5447d1021b4260fa401

drm_hwcomposer: CI: Raise clang-tidy level from NONE to COARSE for *.h

To improve CI coverage.

Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>

DrmHwcTwo.h

diff --git a/DrmHwcTwo.h b/DrmHwcTwo.h
index beb2e5f..f8c3e77 100644
--- a/DrmHwcTwo.h
+++ b/DrmHwcTwo.h
@@ -18,9 +18,9 @@
 #define ANDROID_DRM_HWC_TWO_H_
 
 #include <hardware/hwcomposer2.h>
-#include <math.h>
 
 #include <array>
+#include <cmath>
 #include <map>
 #include <optional>
 
@@ -87,16 +87,16 @@
 
     void PopulateDrmLayer(DrmHwcLayer *layer);
 
-    bool RequireScalingOrPhasing() {
+    bool RequireScalingOrPhasing() const {
       float src_width = source_crop_.right - source_crop_.left;
       float src_height = source_crop_.bottom - source_crop_.top;
 
-      float dest_width = display_frame_.right - display_frame_.left;
-      float dest_height = display_frame_.bottom - display_frame_.top;
+      auto dest_width = float(display_frame_.right - display_frame_.left);
+      auto dest_height = float(display_frame_.bottom - display_frame_.top);
 
       bool scaling = src_width != dest_width || src_height != dest_height;
-      bool phasing = (source_crop_.left - floor(source_crop_.left) != 0) ||
-                     (source_crop_.top - floor(source_crop_.top) != 0);
+      bool phasing = (source_crop_.left - std::floor(source_crop_.left) != 0) ||
+                     (source_crop_.top - std::floor(source_crop_.top) != 0);
       return scaling || phasing;
     }
 
@@ -132,9 +132,9 @@
     HWC2::Composition sf_type_ = HWC2::Composition::Invalid;
     HWC2::Composition validated_type_ = HWC2::Composition::Invalid;
 
-    buffer_handle_t buffer_ = NULL;
+    buffer_handle_t buffer_ = nullptr;
     hwc_rect_t display_frame_;
-    float alpha_ = 1.0f;
+    float alpha_ = 1.0F;
     hwc_frect_t source_crop_;
     DrmHwcTransform transform_ = DrmHwcTransform::kIdentity;
     uint32_t z_order_ = 0;
@@ -234,7 +234,7 @@
 
     /* Statistics */
     struct Stats {
-      Stats minus(Stats b) {
+      Stats minus(Stats b) const {
         return {total_frames_ - b.total_frames_,
                 total_pixops_ - b.total_pixops_,
                 gpu_pixops_ - b.gpu_pixops_,
@@ -257,7 +257,7 @@
       DrmMode mode;
       bool disabled{};
 
-      bool IsInterlaced() {
+      bool IsInterlaced() const {
         return (mode.flags() & DRM_MODE_FLAG_INTERLACE) != 0;
       }
     };
@@ -357,8 +357,8 @@
     std::unique_ptr<Backend> backend_;
 
     VSyncWorker vsync_worker_;
-    DrmConnector *connector_ = NULL;
-    DrmCrtc *crtc_ = NULL;
+    DrmConnector *connector_ = nullptr;
+    DrmCrtc *crtc_ = nullptr;
     hwc2_display_t handle_;
     HWC2::DisplayType type_;
     uint32_t layer_idx_ = 0;