| commit | e11f723f5671dea75caa291f319925581ddfdf5d | [log] [tgz] |
|---|---|---|
| author | Paz Zcharya <pazz@google.com> | Sat Oct 26 21:11:29 2024 +0000 |
| committer | Paz Zcharya <pazz@google.com> | Tue Oct 29 21:13:31 2024 +0000 |
| tree | a2d95277931563791352ae45f090c18b02d6de2b | |
| parent | b6eb4b8d859d92bbbee8e7ae8a7ea4d4869a7968 [diff] |
drm_hwcomposer: Query property when checking virtual displays availability The current implementation of "getMaxVirtualDisplayCount" function relies on the number of writeback connectors, but doesn't consider the availability of CRTCs. Since CRTCs can only be bound to a single pipeline, even though there are available writeback connectors, we might fail to create a virtual pipeline if the CRTCs are being used. This leads to failures in the "CreateVirtualDisplay" and "SetOutputBuffer" VTS tests because the tests expect the creation of a virtual pipeline to work based on the positive value returned by "getMaxVirtualDisplayCount". The virtual display feature in drm-hwcomposer is experimental and currently unused. To address test failures, modify the function "getMaxVirtualDisplayCount" to return 0 unless the property "vendor.vendor.hwc.drm.enable_virtual_display" is explicitly set to true. Signed-off-by: Paz Zcharya <pazz@google.com>
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms. So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
Submit changes via gitlab merge requests on gitlab.freedesktop.org.
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/.
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
git diff | clang-format-diff-19 -p 1 -style=file
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues.
Happy hacking!