Gitiles
Code Review Sign In
gerrit.omnirom.org / android_external_drm_hwcomposer / db440a92e1e337958b6eebdb3c55fbe843e6269c
commitdb440a92e1e337958b6eebdb3c55fbe843e6269c[log] [tgz]
authorAlexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>Thu Mar 29 14:38:21 2018 +0100
committerAlexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>Fri Jul 13 15:38:20 2018 +0100
treeda851a6e85594484a2ce2a66607e13cff25575fc
parentb46b930e54a54bad0926efb4c36688feaa54764e [diff]
drm_hwcomposer: Fix race in ApplyFrame

ApplyFrame holds the lock just when it swaps the value of
active_composition_, in a multithread context we could end up in a
situation where something is shown on the screen, but something else
is set in active_composition_. Fix it by holding the lock during
CommitFrame.

Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
1 file changed
tree: da851a6e85594484a2ce2a66607e13cff25575fc
  1. tests/
  2. .clang-format
  3. .gitlab-ci.yml
  4. Android.mk
  5. autofd.h
  6. autolock.cpp
  7. autolock.h
  8. drmconnector.cpp
  9. drmconnector.h
  10. drmcrtc.cpp
  11. drmcrtc.h
  12. drmdevice.cpp
  13. drmdevice.h
  14. drmdisplaycomposition.cpp
  15. drmdisplaycomposition.h
  16. drmdisplaycompositor.cpp
  17. drmdisplaycompositor.h
  18. drmencoder.cpp
  19. drmencoder.h
  20. drmeventlistener.cpp
  21. drmeventlistener.h
  22. drmframebuffer.h
  23. drmhwcgralloc.h
  24. drmhwcomposer.h
  25. drmhwctwo.cpp
  26. drmhwctwo.h
  27. drmmode.cpp
  28. drmmode.h
  29. drmplane.cpp
  30. drmplane.h
  31. drmproperty.cpp
  32. drmproperty.h
  33. hwcutils.cpp
  34. MODULE_LICENSE_APACHE2
  35. NOTICE
  36. platform.cpp
  37. platform.h
  38. platformdrmgeneric.cpp
  39. platformdrmgeneric.h
  40. platformhisi.cpp
  41. platformhisi.h
  42. platformminigbm.cpp
  43. platformminigbm.h
  44. README.md
  45. resourcemanager.cpp
  46. resourcemanager.h
  47. vsyncworker.cpp
  48. vsyncworker.h
  49. worker.cpp
  50. worker.h
README.md

drm_hwcomposer

Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms So please bring on porting patches, bugfixes, improvements for documentation and new features.

A short list of contribution guidelines:

  • Submit changes via gitlab merge requests on gitlab.freedesktop.org

  • drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/

  • When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:

    `git diff | clang-format-diff-3.5 -p 1 -style=file`

  • Hardware specific changes should be tested on relevant platforms before committing.

If you need inspiration, please checkout our TODO issues

Happy hacking!