commit | 734ee1c2e3d0b2c39f111db8efbf253bc17005b8 | [log] [tgz] |
---|---|---|
author | John Stultz <john.stultz@linaro.org> | Wed Jan 09 14:54:52 2019 -0800 |
committer | John Stultz <john.stultz@linaro.org> | Tue Jan 15 10:53:46 2019 -0800 |
tree | a79db90a0751e629bc89f96e0dd215b332cba37f | |
parent | 5047b229d8ca076d6a4631e5e58867f674a04749 [diff] |
drm_hwcomposer: Rework ValidateDisplay layer check to use if statement rather then switch AOSP's toolchain throws errors on un-annotated switch case fallthroughs. Rather then adding [[fallthrough]] annotations, which would add C++17 syntax, switch to using a if statement instead. Change-Id: Id0b2bf6d365d50e637569f0c4353ceb4fda21c16 Signed-off-by: John Stultz <john.stultz@linaro.org> --- v2: Rework conditional to be more readable as suggested by seanpaul
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
Submit changes via gitlab merge requests on gitlab.freedesktop.org
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
`git diff | clang-format-diff-5.0 -p 1 -style=file`
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues
Happy hacking!