commit | 5b5835675bf202da509bef9440f09237cdf0ee0a | [log] [tgz] |
---|---|---|
author | Drew Davenport <ddavenport@google.com> | Wed Jan 29 09:04:22 2025 -0700 |
committer | Drew Davenport <ddavenport@google.com> | Wed Jan 29 09:09:05 2025 -0700 |
tree | 4c46ca3abcff3a91f353ec5895e2987236a99084 | |
parent | 16d3a2d6e832f120bc384271b76afa01b0c13a21 [diff] |
drm_hwcomposer: Fix bitmask property mask creation Enum properties may have the flag DRM_MODE_PROP_BITMASK to indicate that the enum values should be interpreted as bitshifts. - Add a function DrmProperty::IsBitmask to check if this flag is set - Check that this flag is set in DrmProperty::GetEnumMask - Fix GetEnumMask to interpret the enum value as a bitshift Fixes: da2fcf66 ("drm_hwcomposer: Simplify LayerTransform") Change-Id: Ice50ac23344f508b6dee761a51879da99d848007 Signed-off-by: Drew Davenport <ddavenport@google.com>
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms. So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
Submit changes via gitlab merge requests on gitlab.freedesktop.org.
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/.
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
git diff | clang-format-diff-19 -p 1 -style=file
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues.
Happy hacking!