| commit | a29289940d7cf806029a36e2e01667708294c67b | [log] [tgz] |
|---|---|---|
| author | Lucas Berthou <berlu@google.com> | Tue Jan 07 22:48:28 2025 +0000 |
| committer | Lucas Berthou <berlu@google.com> | Wed Jan 08 18:02:31 2025 +0000 |
| tree | b15f1e58eb889746c4d8fb364a5f2ca9d6f73ef6 | |
| parent | 4483e4731da930544845af8047a026d82f795f60 [diff] |
drm_hwcomposer: fix null deref happening when clearing callback The attempt at clearing the callback happens after the vsync worker has been de-init-ed, the mutex is no longer valid and this causes a crash when trying to guard_lock it. This can be reproduced by unplugging an external monitor. TEST: manual Change-Id: I1eecdee84706683de1c953c17ce26ebfa3a24d9f Signed-off-by: Lucas Berthou <berlu@google.com>
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms. So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
Submit changes via gitlab merge requests on gitlab.freedesktop.org.
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/.
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
git diff | clang-format-diff-19 -p 1 -style=file
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues.
Happy hacking!