commit c46896d6e2d8a5eb12369eece85107958942a3fe
author Roman Stratiienko <roman.o.stratiienko@globallogic.com> Tue Jan 04 11:10:22 2022 +0200
committer Roman Stratiienko <roman.o.stratiienko@globallogic.com> Wed Jan 12 10:47:23 2022 +0200
tree b6a8f4c9d7531a4eacbf10970679cc140059abc7
parent f815d38c2ad191b3cbe7e259b9ef2fc974875b72

drm_hwcomposer: CI: Move tidy FINE checklist to Makefile

To make checklists definitions aligned and allow inheritance.

Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>

.ci/Makefile

diff --git a/.ci/Makefile b/.ci/Makefile
index 20e81ac..3dd1653 100644
--- a/.ci/Makefile
+++ b/.ci/Makefile
@@ -45,10 +45,17 @@
     DrmHwcTwo.cpp:COARSE                                \
     DrmHwcTwo.h:COARSE                                  \
 
-TIDY_CHECKS_NORMAL := * \
-    -hicpp-* -llvmlibc-* -fuchsia-* -altera-* \
+TIDY_CHECKS_FINE := *                                   \
+    -llvmlibc* -fuchsia-* -altera-*                     \
+    -llvm-header-guard                                  \
+    -cppcoreguidelines-pro-type-vararg                  \
+    -hicpp-vararg                                       \
+    -hicpp-signed-bitwise                               \
+
+TIDY_CHECKS_NORMAL :=                                   \
+    $(TIDY_CHECKS_FINE)                                 \
+    -hicpp*                                             \
     -cppcoreguidelines-special-member-functions \
-    -llvm-header-guard \
     -cppcoreguidelines-avoid-c-arrays \
     -cppcoreguidelines-pro-type-vararg \
     -cppcoreguidelines-pro-bounds-array-to-pointer-decay \
@@ -134,9 +141,9 @@
 space := $(subst ,, )
 comma := ,
 
-TIDY_ARGS_FINE :=
 TIDY_ARGS_NONE := --checks="-*,llvm-include-order"
 TIDY_ARGS_     := --checks="-*,llvm-include-order"
+TIDY_ARGS_FINE := --checks="$(subst $(space),$(comma),$(strip $(TIDY_CHECKS_FINE)))"
 TIDY_ARGS_NORMAL := --checks="$(subst $(space),$(comma),$(strip $(TIDY_CHECKS_NORMAL)))"
 TIDY_ARGS_COARSE := --checks="$(subst $(space),$(comma),$(strip $(TIDY_CHECKS_COARSE)))"
 

.clang-tidy

diff --git a/.clang-tidy b/.clang-tidy
index ab83758..3731a29 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -1,14 +1,3 @@
-# fuchsia: Conflicts with other checks
-# llvm-header-guard: Does not match drm_hwc header gusrd style 
-# Allow using ALOGE 
-
-Checks: >
-    *,
-    -fuchsia*,
-    -llvm*,
-    -cppcoreguidelines-pro-type-vararg, -hicpp-vararg,
-    -hicpp-signed-bitwise,
-
 # Turn all the warnings from the checks above into errors.
 WarningsAsErrors: "*"