| commit | acc1c21fadaee888325319d2c8dd2a0995aa2a95 | [log] [tgz] |
|---|---|---|
| author | John Stultz <john.stultz@linaro.org> | Tue Feb 04 21:53:13 2020 +0000 |
| committer | John Stultz <john.stultz@linaro.org> | Tue Feb 04 22:04:09 2020 +0000 |
| tree | 920008d63bfb357d393c7d658e7d362cf507cd70 | |
| parent | b2f2baeb9db0d0f4cbc0cac3184058d3fce85ea6 [diff] |
drm_hwcomposer: Revert "drm_hwcomposer: Extract more BO data by Imagination importer" This reverts commit b2f2baeb9db0d0f4cbc0cac3184058d3fce85ea6. I'm trying to utilize a policy of lighter reviews w/ quick reverts when there are issues to keep things moving. So with that in mind I'm reverting "Extract more BO data by Imagination importer" since its breaking the build in AOSP. See: https://android-review.googlesource.com/c/platform/external/drm_hwcomposer/+/1225155/-1..1#message-828f83ed7fa89b3bdfff7b0b5b1dd7364c822892 https://android-review.googlesource.com/c/platform/external/drm_hwcomposer/+/1225916 This breakage is due to the importer code being tightly tied to the gralloc private handle definitions, which is a common problem as the gralloc and drm_hwcomposers are separately maintained. The beagle_x15 gralloc is apparently older, and doesn't have the newly utilized fields. So for now, revert this to stay in sync w/ AOSP. I'm happy to re-apply as soon as a fix is in place which adds some sort of versioning checks so hopefully drm_hwc can work with different versions of the gralloc code. Once users of the old gralloc code are updated, we can remove such version checks if needed. Change-Id: Ie72561061ea12cb58d3ba9616a62d05f4ffe78b0 Signed-off-by: John Stultz <john.stultz@linaro.org>
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
Submit changes via gitlab merge requests on gitlab.freedesktop.org
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
`git diff | clang-format-diff-5.0 -p 1 -style=file`
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues
Happy hacking!