Gitiles
Code Review Sign In
gerrit.omnirom.org / android_external_drm_hwcomposer / a451483cf1999af2ac76b0e9ab305da3d4392382
commita451483cf1999af2ac76b0e9ab305da3d4392382[log] [tgz]
authorJohn Stultz <john.stultz@linaro.org>Fri Aug 24 16:27:36 2018 -0700
committerJohn Stultz <john.stultz@linaro.org>Fri Aug 31 09:09:56 2018 -0700
treea9e439dc361cf8f1e03005a066428e4239d9b002
parent616fb227d0ae9e823e765e2ee3a7a44be7c3cf37 [diff]
drm_hwcomposer: Store pixel_stride in the hwc_drm_bo

The new GraphicBufferMapper ImportBuffer takes a pixel_stride
as an argument, so we need to caluclate that and store it in
the hwc_drm_bo at import so we can use it here.

I'd still welcome better ideas to calculate pixel_stride for
generic drm importer.

Change-Id: Iea2c483f3750dd5bed38740802b560911bc54ef2
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
v2:
* Utilized pixel stride values already in some gralloc handle
  implementations
* Fixed embarasing bit/byte math snafu (preserving bits per
  pixel since YUV conversions using bytes doesn't seem sane)
    - Extra review still would be appreciated here!
v3:
* Renamed to use Drm... instead of DRM...
5 files changed
tree: a9e439dc361cf8f1e03005a066428e4239d9b002
  1. tests/
  2. .clang-format
  3. .gitlab-ci.yml
  4. Android.mk
  5. autofd.h
  6. autolock.cpp
  7. autolock.h
  8. drmconnector.cpp
  9. drmconnector.h
  10. drmcrtc.cpp
  11. drmcrtc.h
  12. drmdevice.cpp
  13. drmdevice.h
  14. drmdisplaycomposition.cpp
  15. drmdisplaycomposition.h
  16. drmdisplaycompositor.cpp
  17. drmdisplaycompositor.h
  18. drmencoder.cpp
  19. drmencoder.h
  20. drmeventlistener.cpp
  21. drmeventlistener.h
  22. drmframebuffer.h
  23. drmhwcgralloc.h
  24. drmhwcomposer.h
  25. drmhwctwo.cpp
  26. drmhwctwo.h
  27. drmmode.cpp
  28. drmmode.h
  29. drmplane.cpp
  30. drmplane.h
  31. drmproperty.cpp
  32. drmproperty.h
  33. hwcutils.cpp
  34. MODULE_LICENSE_APACHE2
  35. NOTICE
  36. platform.cpp
  37. platform.h
  38. platformdrmgeneric.cpp
  39. platformdrmgeneric.h
  40. platformhisi.cpp
  41. platformhisi.h
  42. platformminigbm.cpp
  43. platformminigbm.h
  44. README.md
  45. resourcemanager.cpp
  46. resourcemanager.h
  47. vsyncworker.cpp
  48. vsyncworker.h
  49. worker.cpp
  50. worker.h
README.md

drm_hwcomposer

Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms So please bring on porting patches, bugfixes, improvements for documentation and new features.

A short list of contribution guidelines:

  • Submit changes via gitlab merge requests on gitlab.freedesktop.org

  • drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/

  • When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:

    `git diff | clang-format-diff-3.5 -p 1 -style=file`

  • Hardware specific changes should be tested on relevant platforms before committing.

If you need inspiration, please checkout our TODO issues

Happy hacking!