| commit | 9c41b68d080445f80fa144ce4e69620da270877e | [log] [tgz] |
|---|---|---|
| author | Paz Zcharya <pazz@google.com> | Tue Nov 05 19:07:31 2024 +0000 |
| committer | Paz Zcharya <pazz@google.com> | Tue Nov 05 20:10:45 2024 +0000 |
| tree | 41b1f52e8bf4ecc17e6d4d9f3f5b227662f82289 | |
| parent | 556f56b4db33b2bd407fc85735e84277b3da86a5 [diff] |
drm_hwcomposer: Fix build failure on Linux-native targets
Commit e11f723f ("drm_hwcomposer: Query property when checking virtual
displays availability") introduced a call to
android::base::GetBoolProperty, which is only available in Android.
This caused the test "hwcomposer.filegroups_build_test" to fail because
the code was no longer compiling for Linux-native targets.
Fix that by replacing "android::base::GetBoolProperty" with a new
function "property_get_bool," and define the function for both Android
and non-Android targets:
For Android, utilize the existing function from <cutils/properties.h>
For other targets, a new implementation is provided in
utils/properties.h.
Fixes: e11f723f ("drm_hwcomposer: Query property when checking virtual
displays availability")
Signed-off-by: Paz Zcharya <pazz@google.com>
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms. So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
Submit changes via gitlab merge requests on gitlab.freedesktop.org.
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/.
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
git diff | clang-format-diff-19 -p 1 -style=file
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues.
Happy hacking!