| commit | 921c1cdce5c8655b8520b87b848ed9300d397066 | [log] [tgz] |
|---|---|---|
| author | Sasha McIntosh <sashamcintosh@google.com> | Wed Oct 09 19:50:52 2024 -0400 |
| committer | Sasha McIntosh <sashamcintosh@google.com> | Mon Oct 14 17:34:12 2024 -0400 |
| tree | 2af4e593ece45e9654102d2b18cf1b58208d8ce1 | |
| parent | a37df7ca76ea516a0aef036ea1c72ba9c97d6501 [diff] |
drm_hwcomposer: Correct CTM conversion Correctly compute the CTM given the HAL interface. HAL provides a 4x4 float type matrix: | 0 1 2 3| | 4 5 6 7| | 8 9 10 11| |12 13 14 15| This is to be interpreted as out matrix in offset |R| |0 4 8| |R| |12| |G| = |1 5 9| x |G| + |13| |B| |2 6 10| |B| |14| DRM expects a 3x3 s31.32 fixed point matrix interpreted as |R| |0 1 2| |R| |G| = |3 4 5| x |G| |B| |6 7 8| |B| DRM does not support an offset vector, so we reject any color transform matrices that have one. Change-Id: I323fde281c8a97cf319bb9774eb232abcc8bde34 Signed-off-by: Sasha McIntosh <sashamcintosh@google.com>
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms. So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
Submit changes via gitlab merge requests on gitlab.freedesktop.org.
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/.
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
git diff | clang-format-diff-15 -p 1 -style=file
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues.
Happy hacking!