Gitiles
Code Review Sign In
gerrit.omnirom.org / android_external_drm_hwcomposer / 78c9f6c26210423926ea027edfab0b9504c2d7ff
commit78c9f6c26210423926ea027edfab0b9504c2d7ff[log] [tgz]
authorJohn Stultz <john.stultz@linaro.org>Thu May 24 16:43:35 2018 -0700
committerJohn Stultz <john.stultz@linaro.org>Thu Jun 21 13:53:23 2018 -0700
treec8d517248ae2761b34b8e912ec363b02954f657b
parentdf35a81f49c9c0ed4fa9e2f00b1b99ccd36a8407 [diff]
drm_hwcomposer: Avoid filling the log with warnings when test compositions fail

We frequently test compositions that might fail due to various
reasons. On db820 we see:

 W HwcComposer: command 0x4010000 generated error 8
 E hwc-drm-display-compositor: Alpha is not supported on plane 29
 E hwc-drm-two: Failed to apply the frame composition ret=-22

over and over

So to avoid filling the log with errors when those test
compsitions don't work out, this patch tries to quiet down those
error messages when we are doing test compositions.

Change-Id: Iab19628bd7488c7d104e2c775310989bb59e140d
Signed-off-by: John Stultz <john.stultz@linaro.org>
2 files changed
tree: c8d517248ae2761b34b8e912ec363b02954f657b
  1. tests/
  2. .clang-format
  3. .gitlab-ci.yml
  4. Android.mk
  5. autofd.h
  6. autolock.cpp
  7. autolock.h
  8. drmconnector.cpp
  9. drmconnector.h
  10. drmcrtc.cpp
  11. drmcrtc.h
  12. drmdisplaycomposition.cpp
  13. drmdisplaycomposition.h
  14. drmdisplaycompositor.cpp
  15. drmdisplaycompositor.h
  16. drmencoder.cpp
  17. drmencoder.h
  18. drmeventlistener.cpp
  19. drmeventlistener.h
  20. drmframebuffer.h
  21. drmhwcgralloc.h
  22. drmhwcomposer.h
  23. drmhwctwo.cpp
  24. drmhwctwo.h
  25. drmmode.cpp
  26. drmmode.h
  27. drmplane.cpp
  28. drmplane.h
  29. drmproperty.cpp
  30. drmproperty.h
  31. drmresources.cpp
  32. drmresources.h
  33. hwcutils.cpp
  34. MODULE_LICENSE_APACHE2
  35. NOTICE
  36. platform.cpp
  37. platform.h
  38. platformdrmgeneric.cpp
  39. platformdrmgeneric.h
  40. platformhisi.cpp
  41. platformhisi.h
  42. platformminigbm.cpp
  43. platformminigbm.h
  44. README.md
  45. vsyncworker.cpp
  46. vsyncworker.h
  47. worker.cpp
  48. worker.h
README.md

drm_hwcomposer

Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms So please bring on porting patches, bugfixes, improvements for documentation and new features.

A short list of contribution guidelines:

  • Submit changes via gitlab merge requests on gitlab.freedesktop.org

  • drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/

  • When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:

    `git diff | clang-format-diff-3.5 -p 1 -style=file`

  • Hardware specific changes should be tested on relevant platforms before committing.

If you need inspiration, please checkout our TODO issues

Happy hacking!