Gitiles
Code Review Sign In
gerrit.omnirom.org / android_external_drm_hwcomposer / 32685ba1e6159d884412d741fb62051c677512ca
commit32685ba1e6159d884412d741fb62051c677512ca[log] [tgz]
authorRoman Stratiienko <roman.o.stratiienko@globallogic.com>Wed Dec 15 13:46:05 2021 +0200
committerRoman Stratiienko <roman.o.stratiienko@globallogic.com>Wed Dec 29 18:03:11 2021 +0200
tree98d220efe5af9cc00698e9304b5cc50e59dba249
parentcef5c77ef971604d2c513c1056222fbb695da1b9 [diff]
drm_hwcomposer: Rework KMS state tracking

1. Store only FrameBuffer shared handle to keep buffer alive while
it is a part of active composition.
2. Store used planes to allow clearing of the composition.

Before this both of mentioned above was a part of DrmDisplayComposition.
Any external modification DrmDisplayComposition caused framebuffer object
to be destroyed, which forced screen to go blank.

We want to modify DrmDisplayComposition, to allow re-using previous
composition data.

This change will also help us tracking STAGED frame state and
migrate to non-blocking atomic commit.

Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Tested-by: Martin Juecker <martin.juecker@gmail.com>
Reviewed-by: Matvii Zorin <matvii.zorin@globallogic.com>
2 files changed
tree: 98d220efe5af9cc00698e9304b5cc50e59dba249
  1. .ci/
  2. backend/
  3. bufferinfo/
  4. compositor/
  5. drm/
  6. include/
  7. tests/
  8. utils/
  9. .clang-format
  10. .clang-tidy
  11. .gitlab-ci.yml
  12. Android.bp
  13. DrmHwcTwo.cpp
  14. DrmHwcTwo.h
  15. MODULE_LICENSE_APACHE2
  16. NOTICE
  17. presubmit.sh
  18. README.md
README.md

drm_hwcomposer

Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms. So please bring on porting patches, bugfixes, improvements for documentation and new features.

A short list of contribution guidelines:

  • Submit changes via gitlab merge requests on gitlab.freedesktop.org.

  • drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/.

  • When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:

    git diff | clang-format-diff-12 -p 1 -style=file

  • Hardware specific changes should be tested on relevant platforms before committing.

If you need inspiration, please checkout our TODO issues.

Happy hacking!