Gitiles
Code Review Sign In
gerrit.omnirom.org / android_external_drm_hwcomposer / c660b3d685745c370434003e4f29d9d7eeb17eed
commitc660b3d685745c370434003e4f29d9d7eeb17eed[log] [tgz]
authorJohn Stultz <john.stultz@linaro.org>Tue May 29 16:50:23 2018 -0700
committerJohn Stultz <john.stultz@linaro.org>Wed May 30 10:19:04 2018 -0700
tree28b172621d48a6ba0019bff49b7e18ff12ee2514
parent1d224e83270be782040e00a8eb51d4b20dc740d0 [diff]
drm_hwcomposer: Try to fix clang-format pipeline

The clang-format pipeline generates false negatives
sometimes, with:

$ git diff -U0 --no-color master...HEAD | clang-format-diff-3.5 -p 1 -style=file > format-fixup.patch
fatal: ambiguous argument 'master...HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:

as seen here:
https://gitlab.freedesktop.org/john.stultz/drm-hwcomposer/-/jobs/932

This tries to address the issue by explictly fetching
freedesktop/master and referencing FETHC_HEAD instead of master
which doesn't always exist.

Change-Id: I7a07d412eae164841427da90dfc7298697c5e783
Reviewed-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
Signed-off-by: John Stultz <john.stultz@linaro.org>
1 file changed
tree: 28b172621d48a6ba0019bff49b7e18ff12ee2514
  1. tests/
  2. .clang-format
  3. .gitlab-ci.yml
  4. Android.mk
  5. autofd.h
  6. autogl.h
  7. autolock.cpp
  8. autolock.h
  9. drmcompositorworker.cpp
  10. drmconnector.cpp
  11. drmconnector.h
  12. drmcrtc.cpp
  13. drmcrtc.h
  14. drmdisplaycomposition.cpp
  15. drmdisplaycomposition.h
  16. drmdisplaycompositor.cpp
  17. drmdisplaycompositor.h
  18. drmencoder.cpp
  19. drmencoder.h
  20. drmeventlistener.cpp
  21. drmeventlistener.h
  22. drmframebuffer.h
  23. drmhwcgralloc.h
  24. drmhwcomposer.h
  25. drmhwctwo.cpp
  26. drmhwctwo.h
  27. drmmode.cpp
  28. drmmode.h
  29. drmplane.cpp
  30. drmplane.h
  31. drmproperty.cpp
  32. drmproperty.h
  33. drmresources.cpp
  34. drmresources.h
  35. glworker.cpp
  36. glworker.h
  37. hwcomposer.cpp
  38. hwcutils.cpp
  39. MODULE_LICENSE_APACHE2
  40. NOTICE
  41. platform.cpp
  42. platform.h
  43. platformdrmgeneric.cpp
  44. platformdrmgeneric.h
  45. platformhisi.cpp
  46. platformhisi.h
  47. platformminigbm.cpp
  48. platformminigbm.h
  49. README.md
  50. separate_rects.cpp
  51. separate_rects.h
  52. virtualcompositorworker.cpp
  53. virtualcompositorworker.h
  54. vsyncworker.cpp
  55. vsyncworker.h
  56. worker.cpp
  57. worker.h
README.md

drm_hwcomposer

Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms So please bring on porting patches, bugfixes, improvements for documentation and new features.

A short list of contribution guidelines:

  • Submit changes via gitlab merge requests on gitlab.freedesktop.org

  • drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/

  • When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:

    `git diff | clang-format-diff-3.5 -p 1 -style=file`

  • Hardware specific changes should be tested on relevant platforms before committing.

If you need inspiration, please checkout our TODO issues

Happy hacking!