| commit | eb012298f3109e2faa651e881362aca8bc243d8f | [log] [tgz] |
|---|---|---|
| author | Liviu Dudau <Liviu.Dudau@arm.com> | Mon Jun 15 17:08:33 2020 +0100 |
| committer | John Stultz <john.stultz@linaro.org> | Fri Jul 03 19:10:22 2020 +0000 |
| tree | 9f6cb51297dea20349c7aa6af4590410cfdc940c | |
| parent | fdcdeabd7e50f2ff005333b135c1d0b440296a85 [diff] |
drm_hwcomposer: Fix ValidateDisplay() when lowest z-order is nonzero
ValidateDisplay()'s algorithm for achieving minimal GPU load assumes
that the lowest z-order is zero and that layers have sequential z-orders.
CalcPixOps() and MarkValidated() are also written with the same assumption.
However, there is no such guarantee provided by SurfaceFlinger and VTS
tests like PRESENT_DISPLAY_NO_LAYER_STATE_CHANGES fail as they only have
one layer with z-order of 10.
Normalise the mapping between layers and z-order so that the algorithm works
as intended.
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Fixes commit b7b81cfba252 ("drm_hwcomposer: Choose client layer range to
achieve minimal GPU load")
Signed-off-by: John Stultz <john.stultz@linaro.org>
Change-Id: I71b76b9d151bf506ad6026f5b1f9de6b6c0dc7c1
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
Submit changes via gitlab merge requests on gitlab.freedesktop.org
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
`git diff | clang-format-diff-5.0 -p 1 -style=file`
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues
Happy hacking!