Gitiles
Code Review Sign In
gerrit.omnirom.org / android_external_drm_hwcomposer / ad43886f7d5eb35965fd94fb73a6bdcdbe180d5c
commitad43886f7d5eb35965fd94fb73a6bdcdbe180d5c[log] [tgz]
authorMykhailo Sopiha <mykhailo.sopiha@linaro.org>Thu Jun 06 14:45:27 2019 +0300
committerMykhailo Sopiha <mykhailo.sopiha@linaro.org>Fri Jun 07 12:31:45 2019 +0300
treeef10c2e47aa7c595aab24d8ee5de1126b6f95eea
parent9cf798da27ba1f902f53c3d1e7140922711ca4b2 [diff]
drm_hwcomposer: clean Importer inherited classes

Move some common logic from Importer class implementations
into DrmGenericImporter class:
 - reused generic constructors and destructors for derived
   classes
 - formed common Init() logic for all derived classes
 - removed unused gralloc_ and drm_ variables from derived
   classes
 - made drm_ protected for base class to be reused in derived

Signed-off-by: Mykhailo Sopiha <mykhailo.sopiha@linaro.org>
6 files changed
tree: ef10c2e47aa7c595aab24d8ee5de1126b6f95eea
  1. tests/
  2. .clang-format
  3. .gitlab-ci-checkcommit.sh
  4. .gitlab-ci.yml
  5. Android.bp
  6. autofd.h
  7. autolock.cpp
  8. autolock.h
  9. drmconnector.cpp
  10. drmconnector.h
  11. drmcrtc.cpp
  12. drmcrtc.h
  13. drmdevice.cpp
  14. drmdevice.h
  15. drmdisplaycomposition.cpp
  16. drmdisplaycomposition.h
  17. drmdisplaycompositor.cpp
  18. drmdisplaycompositor.h
  19. drmencoder.cpp
  20. drmencoder.h
  21. drmeventlistener.cpp
  22. drmeventlistener.h
  23. drmframebuffer.h
  24. drmhwcgralloc.h
  25. drmhwcomposer.h
  26. drmhwctwo.cpp
  27. drmhwctwo.h
  28. drmmode.cpp
  29. drmmode.h
  30. drmplane.cpp
  31. drmplane.h
  32. drmproperty.cpp
  33. drmproperty.h
  34. hwcutils.cpp
  35. MODULE_LICENSE_APACHE2
  36. NOTICE
  37. platform.cpp
  38. platform.h
  39. platformdrmgeneric.cpp
  40. platformdrmgeneric.h
  41. platformhisi.cpp
  42. platformhisi.h
  43. platformminigbm.cpp
  44. platformminigbm.h
  45. README.md
  46. resourcemanager.cpp
  47. resourcemanager.h
  48. vsyncworker.cpp
  49. vsyncworker.h
  50. worker.cpp
  51. worker.h
README.md

drm_hwcomposer

Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms So please bring on porting patches, bugfixes, improvements for documentation and new features.

A short list of contribution guidelines:

  • Submit changes via gitlab merge requests on gitlab.freedesktop.org

  • drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/

  • When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:

    `git diff | clang-format-diff-5.0 -p 1 -style=file`

  • Hardware specific changes should be tested on relevant platforms before committing.

If you need inspiration, please checkout our TODO issues

Happy hacking!