| commit | 30f4e9c5938a906120ff13260acde9bdcc4317b0 | [log] [tgz] |
|---|---|---|
| author | Drew Davenport <ddavenport@google.com> | Mon Dec 16 16:12:11 2024 -0700 |
| committer | Drew Davenport <ddavenport@google.com> | Mon Dec 16 17:53:54 2024 -0700 |
| tree | 30050f7d4029dc69be7f8f0f51338910bdc9e4e4 | |
| parent | 15016c496c156efeab566d15a2582e3ab02c0cc1 [diff] |
drm_hwcomposer: Clean up VsyncWorker destruction With VsyncWorker no longer acquiring the main lock, we can use std::thread::join on the main thread to ensure that the vsync thread is stopped cleanly in the VSyncWorker destructor. - Don't pass a shared_ptr<> into VSyncWorker::ThreadFn to simplify lifetime management - Change to unique_ptr to simplify lifetime management - Remove the hack to destroy the HwcDisplays in two stages when destructing ComposerClient - Add std::thread::join to VSyncWorker destructor Change-Id: I25a34fd304c7b2ec48e43d538bf15794bdc9d68e Signed-off-by: Drew Davenport <ddavenport@google.com>
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms. So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
Submit changes via gitlab merge requests on gitlab.freedesktop.org.
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/.
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
git diff | clang-format-diff-19 -p 1 -style=file
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues.
Happy hacking!