| commit | 3f4469f92ae7de6ab9fe7ac3f9c920b09eb53c27 | [log] [tgz] |
|---|---|---|
| author | Drew Davenport <ddavenport@google.com> | Thu Oct 03 10:01:51 2024 -0600 |
| committer | John Stultz <jstultz@google.com> | Mon Oct 07 20:43:43 2024 +0000 |
| tree | 5ba5d46f92e6b9c1cd0d0a9086fc7ab5a38e8f76 | |
| parent | d82729393ce27104160e5e990e30d422f9ae3202 [diff] |
drm_hwcomposer: Set correct size for changed composition types Call HwcDisplay::GetChangedCompositionTypes with nullptrs to get the correct expected number of changed composition types. Resizing this incorrectly resulted in entries for default-initialized layer id (0), leading to log spam and possibly impacting performance as well. Addresses the log spam reported in #95. Change-Id: I84046f9bc461656214f0a1f0ca0c440a7189505b Signed-off-by: Drew Davenport <ddavenport@google.com>
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms. So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
Submit changes via gitlab merge requests on gitlab.freedesktop.org.
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/.
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
git diff | clang-format-diff-15 -p 1 -style=file
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues.
Happy hacking!