drm_hwcomposer: Validate gralloc0 name for minigbm and libdrm getters
Using of incorrect gralloc0 results in a runtime issues, with logs like
"Cannot convert hal format to drm format <VALUE>" or other.
Validate gralloc name and exit gracefully in case it doesnt't match the one
we are expecting.
Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
diff --git a/bufferinfo/legacy/BufferInfoLibdrm.cpp b/bufferinfo/legacy/BufferInfoLibdrm.cpp
index 6243d8d..e70536b 100644
--- a/bufferinfo/legacy/BufferInfoLibdrm.cpp
+++ b/bufferinfo/legacy/BufferInfoLibdrm.cpp
@@ -204,4 +204,20 @@
return 0;
}
+constexpr char gbm_gralloc_module_name[] = "GBM Memory Allocator";
+constexpr char drm_gralloc_module_name[] = "DRM Memory Allocator";
+
+int BufferInfoLibdrm::ValidateGralloc() {
+ if (strcmp(gralloc_->common.name, drm_gralloc_module_name) != 0 &&
+ strcmp(gralloc_->common.name, gbm_gralloc_module_name) != 0) {
+ ALOGE(
+ "Gralloc name isn't valid: Expected: \"%s\" or \"%s\", Actual: \"%s\"",
+ gbm_gralloc_module_name, drm_gralloc_module_name,
+ gralloc_->common.name);
+ return -EINVAL;
+ }
+
+ return 0;
+}
+
} // namespace android