| commit | 32170177d3d9579c2eb7291a71246f39ba434c9b | [log] [tgz] |
|---|---|---|
| author | Mattijs Korpershoek <mkorpershoek@baylibre.com> | Fri Oct 11 16:57:36 2024 +0200 |
| committer | Sasha McIntosh <sashamcintosh@google.com> | Mon Oct 14 17:34:12 2024 -0400 |
| tree | bc5b992c3da8936aa29f0a59dfbeae717bd8f823 | |
| parent | 921c1cdce5c8655b8520b87b848ed9300d397066 [diff] |
drm_hwcomposer: CI: Use upstream container image conditionally Right now we use $CI_REGISTRY_IMAGE:latest as the docker image for running build, tidy and checkstyle. The problem with this is that CI_REGISTRY_IMAGE points to the *fork*'s container registry. For example, if the ddavenport user has this fork: https://gitlab.freedesktop.org/ddavenport/drm-hwcomposer Then CI_REGISTRY_IMAGE will be: registry.freedesktop.org/ddavenport/drm-hwcomposer This won't work for forks that never build the container image. Use registry.freedesktop.org/drm-hwcomposer/drm-hwcomposer:latest as container image by default. For MRs that modify .ci/Dockerfile, a container will be rebuild and the forks image will be used instead. Link: https://gitlab.freedesktop.org/drm-hwcomposer/drm-hwcomposer/-/issues/97 Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms. So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
Submit changes via gitlab merge requests on gitlab.freedesktop.org.
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/.
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
git diff | clang-format-diff-15 -p 1 -style=file
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues.
Happy hacking!