Gitiles
Code Review Sign In
gerrit.omnirom.org / android_external_drm_hwcomposer / 2ed463c2fdb57657378743a44129b1e4b4db0656
commit2ed463c2fdb57657378743a44129b1e4b4db0656[log] [tgz]
authorAlexandru Gheorghe <alexc.g1.ro@gmail.com>Tue Jan 08 19:21:08 2019 +0200
committerSean Paul <seanpaul@chromium.org>Mon Mar 18 14:28:45 2019 +0000
tree30092350dce77c2cac43dee68d9662b54712eaed
parent2689aeb8b2e8c8c4af059a2ec4ae1410a03f4640 [diff]
drm_hwcomposer: Set zpos relative to the minimum possible value

Current implementation doesn't handle properly the cases where zpos
range starts from 1.
See https://gitlab.freedesktop.org/drm-hwcomposer/drm-hwcomposer/issues/19#note_100622

Fixes: ea1c5e5a ("drm_hwcomposer: Add z order support")

Signed-off-by: Alexandru Gheorghe <alexc.g1.ro@gmail.com>
[seanpaul converted to std::tuple return type]
Signed-off-by: Sean Paul <seanpaul@chromium.org>

Change-Id: I35dc2c1cfd0e38ca3a47cf4e668eeb5f3c470ddb
3 files changed
tree: 30092350dce77c2cac43dee68d9662b54712eaed
  1. tests/
  2. .clang-format
  3. .gitlab-ci-checkcommit.sh
  4. .gitlab-ci.yml
  5. Android.mk
  6. autofd.h
  7. autolock.cpp
  8. autolock.h
  9. drmconnector.cpp
  10. drmconnector.h
  11. drmcrtc.cpp
  12. drmcrtc.h
  13. drmdevice.cpp
  14. drmdevice.h
  15. drmdisplaycomposition.cpp
  16. drmdisplaycomposition.h
  17. drmdisplaycompositor.cpp
  18. drmdisplaycompositor.h
  19. drmencoder.cpp
  20. drmencoder.h
  21. drmeventlistener.cpp
  22. drmeventlistener.h
  23. drmframebuffer.h
  24. drmhwcgralloc.h
  25. drmhwcomposer.h
  26. drmhwctwo.cpp
  27. drmhwctwo.h
  28. drmmode.cpp
  29. drmmode.h
  30. drmplane.cpp
  31. drmplane.h
  32. drmproperty.cpp
  33. drmproperty.h
  34. hwcutils.cpp
  35. MODULE_LICENSE_APACHE2
  36. NOTICE
  37. platform.cpp
  38. platform.h
  39. platformdrmgeneric.cpp
  40. platformdrmgeneric.h
  41. platformhisi.cpp
  42. platformhisi.h
  43. platformminigbm.cpp
  44. platformminigbm.h
  45. README.md
  46. resourcemanager.cpp
  47. resourcemanager.h
  48. vsyncworker.cpp
  49. vsyncworker.h
  50. worker.cpp
  51. worker.h
README.md

drm_hwcomposer

Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms So please bring on porting patches, bugfixes, improvements for documentation and new features.

A short list of contribution guidelines:

  • Submit changes via gitlab merge requests on gitlab.freedesktop.org

  • drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/

  • When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:

    `git diff | clang-format-diff-5.0 -p 1 -style=file`

  • Hardware specific changes should be tested on relevant platforms before committing.

If you need inspiration, please checkout our TODO issues

Happy hacking!