| commit | 210c2ceb691ac1b2e7eb3b7195d5fe1e20386d07 | [log] [tgz] |
|---|---|---|
| author | Lucas Berthou <berlu@google.com> | Tue Oct 15 15:31:57 2024 +0000 |
| committer | Lucas Berthou <berlu@google.com> | Wed Oct 30 19:07:05 2024 +0000 |
| tree | b7d47ad2b236b4dab937ad2d2d8490ad0540aed1 | |
| parent | e11f723f5671dea75caa291f319925581ddfdf5d [diff] |
Revert "drm_hwcomposer: Workaround for screen de-activating causing db845c regression" This workaround actually leaves pipes in an unclean state on external displays which leads to planes bleeding and incorrect renderings in the case of overlays being assigned to external displays. There is also a case to be made to not have board specific hacks in drm_hwc and we should fine a better solution if this is still a problem. We could consider only deactivating non-primary display if the new pipeline is set to null for instance. This reverts commit 799e8c74c65e5d12d354a0b3f2b541f3d44273a2. Change-Id: Ia28f9e3b0a9ee81ff934143bd2aba526219b76e4 Signed-off-by: Lucas Berthou <berlu@google.com>
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms. So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
Submit changes via gitlab merge requests on gitlab.freedesktop.org.
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/.
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
git diff | clang-format-diff-19 -p 1 -style=file
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues.
Happy hacking!