| commit | c56eede3396a4a8aa26126e20bf6d174a6a75f7c | [log] [tgz] |
|---|---|---|
| author | Matteo Franchin <matteo.franchin@arm.com> | Tue Dec 03 17:10:38 2019 +0000 |
| committer | John Stultz <john.stultz@linaro.org> | Tue Dec 03 17:10:38 2019 +0000 |
| tree | 0feac6a020c41028fb6b16cecfc283fa5a28e10a | |
| parent | d6a6e6eadd783365013fdc493c00994054f3e6aa [diff] |
drm_hwcomposer: Fix returned fence in PresentDisplay DrmHwcTwo::HwcDisplay::PresentDisplay was always returning -1 as the present fence. This commits ensures the fence fd is correctly retrieved after doing the commit-frame operation. It also updates outdated logic that caused PresentDisplay to return the retire fence rather than the present fence. DrmHwcTwo::HwcDisplay::AddFenceToPresentFence is also changed so that it assumes it is given ownership of the file descriptor it receives as argument. This function was indeed called consistently with this behaviour, which meant the dup led to leakage of file descriptors. With the changes above this patch fixes a failure in the CTS test dEQP-VK.wsi.android.display_timing.fifo.display_timing (for example running Android 10 on HiKey960). The test failed with the error "Unexpectedly received invalid timestamp." reported multiple times in the logcat output. Change-Id: If662e5239895b8b0e2ea31fd99747855f901a427 Signed-off-by: Matteo Franchin <matteo.franchin@arm.com>
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
Submit changes via gitlab merge requests on gitlab.freedesktop.org
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
`git diff | clang-format-diff-5.0 -p 1 -style=file`
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues
Happy hacking!