commit 0b06388081572056f6159627500f79d7638a378a
author Roman Stratiienko <roman.o.stratiienko@globallogic.com> Thu Sep 30 10:15:05 2021 +0300
committer Roman Stratiienko <roman.o.stratiienko@globallogic.com> Sat Oct 23 04:47:33 2021 +0300
tree 0e3ed35217cd66e0a18b62f7d03cd54e49a08b41
parent 6748b0962450ac5e3c6c6f9dbb6edc5be96865db

drm_hwcomposer: Move GetPlaneProperty into DrmPlane class

In addition move logging to GetPlaneProperty(), which allow to reduce
number of LoC by ~50 LoC and increase readability.

Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>

drm/DrmDevice.h

diff --git a/drm/DrmDevice.h b/drm/DrmDevice.h
index 04bfe3c..9cbc7df 100644
--- a/drm/DrmDevice.h
+++ b/drm/DrmDevice.h
@@ -69,12 +69,10 @@
   DrmPlane *GetPlane(uint32_t id) const;
   DrmEventListener *event_listener();
 
-  int GetPlaneProperty(const DrmPlane &plane, const char *prop_name,
-                       DrmProperty *property);
   int GetCrtcProperty(const DrmCrtc &crtc, const char *prop_name,
-                      DrmProperty *property);
+                      DrmProperty *property) const;
   int GetConnectorProperty(const DrmConnector &connector, const char *prop_name,
-                           DrmProperty *property);
+                           DrmProperty *property) const;
 
   std::string GetName() const;
 
@@ -98,11 +96,12 @@
 
   static auto IsKMSDev(const char *path) -> bool;
 
- private:
-  int TryEncoderForDisplay(int display, DrmEncoder *enc);
   int GetProperty(uint32_t obj_id, uint32_t obj_type, const char *prop_name,
                   DrmProperty *property) const;
 
+ private:
+  int TryEncoderForDisplay(int display, DrmEncoder *enc);
+
   int CreateDisplayPipe(DrmConnector *connector);
   int AttachWriteback(DrmConnector *display_conn);