| commit | 875f39793ff12f95cf8bd5c66addfa14b3cf01fb | [log] [tgz] |
|---|---|---|
| author | Roman Stratiienko <roman.o.stratiienko@globallogic.com> | Fri Oct 22 12:34:36 2021 +0300 |
| committer | Roman Stratiienko <roman.o.stratiienko@globallogic.com> | Fri Oct 22 23:05:06 2021 +0300 |
| tree | a7d107d04320d889e25acd6fe50a22a39b838c52 | |
| parent | 11ef8c5f6792a128d8419a037ff00b3987d565f1 [diff] |
drm_hwcomposer: Improve Mapper@4 metadata API fds index guessing logic Unfortunately Mapper@4.0 metadata API doesn't allow to query fd index or getting fd another way for every layout plane, therefore users have to provide their custom additional metadata API. We are doing all our best to minimize custom per-platform logic in drm_hwcomposer. So it was decided to implement primitive guessing logic, allowing users to extend it with out-of-tree code if necessary. As was reported by John Stultz in [1] our primitive logic has some flaws. New guessing logic are using inputs from layout data (offsets, sizes), and should be more precise. [1]: https://gitlab.freedesktop.org/drm-hwcomposer/drm-hwcomposer/-/merge_requests/159 Signed-off-by: Roman Stratiienko <roman.o.stratiienko@globallogic.com>
Patches to drm_hwcomposer are very much welcome, we really want this to be the universal HW composer implementation for Android and similar platforms. So please bring on porting patches, bugfixes, improvements for documentation and new features.
A short list of contribution guidelines:
Submit changes via gitlab merge requests on gitlab.freedesktop.org.
drm_hwcomposer is Apache 2.0 Licensed and we require contributions to follow the developer's certificate of origin: http://developercertificate.org/.
When submitting new code please follow the naming conventions documented in the generated documentation. Also please make full use of all the helpers and convenience macros provided by drm_hwcomposer. The below command can help you with formatting of your patches:
git diff | clang-format-diff-12 -p 1 -style=file
Hardware specific changes should be tested on relevant platforms before committing.
If you need inspiration, please checkout our TODO issues.
Happy hacking!