commit b77191c0fa296fc4994955e0918004accd618ea4
author Ricky Niu <rickyniu@google.com> Wed Feb 01 19:40:22 2023 +0800
committer TreeHugger Robot <treehugger-gerrit@google.com> Tue Feb 07 07:30:48 2023 +0000
tree 37236ab0225560273f6e131cc37c2ca9c26fe21e
parent 607ea7aaa7a4a07aad9f749d4bba96a147f35d98

Fix up open bugs from gs101 AIDL migration

1. Remove unused group "wakelock".
2. Correct the right return value on setCurrentUsbFunctions.

Bug: 266694076
Test: Boot to home and function work
Change-Id: If0925a61e481e4deca560dc8dfc1be80a76c148f

usb/gadget/UsbGadget.cpp

diff --git a/usb/gadget/UsbGadget.cpp b/usb/gadget/UsbGadget.cpp
index 2000445..d0e16ee 100644
--- a/usb/gadget/UsbGadget.cpp
+++ b/usb/gadget/UsbGadget.cpp
@@ -546,9 +546,7 @@
     }
 
     ALOGI("Usb Gadget setcurrent functions called successfully");
-    return ScopedAStatus::fromServiceSpecificErrorWithMessage(
-                -1, "Usb Gadget setcurrent functions called successfully");
-
+    return ScopedAStatus::ok();
 
 error:
     ALOGI("Usb Gadget setcurrent functions failed");

usb/gadget/android.hardware.usb.gadget-service.rc

diff --git a/usb/gadget/android.hardware.usb.gadget-service.rc b/usb/gadget/android.hardware.usb.gadget-service.rc
index 3c9c1cc..ba7d5f6 100644
--- a/usb/gadget/android.hardware.usb.gadget-service.rc
+++ b/usb/gadget/android.hardware.usb.gadget-service.rc
@@ -1,8 +1,7 @@
 service vendor.usb-gadget-hal /vendor/bin/hw/android.hardware.usb.gadget-service.gs101
     class hal
     user system
-    group system shell mtp wakelock
-    capabilities WAKE_ALARM BLOCK_SUSPEND
+    group system shell mtp
 
 on post-fs
     chown root system /sys/class/typec/port0/power_role